Assignment instead of comparison in nsOuterDocAccessible::GetChildAtPoint

VERIFIED FIXED in Firefox 5

Status

()

Core
Disability Access APIs
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla6
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(firefox5 fixed)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 526222 [details] [diff] [review]
Patch v1
Attachment #526222 - Flags: review?(surkov.alexander)

Comment 1

6 years ago
Comment on attachment 526222 [details] [diff] [review]
Patch v1

thank you for the catch!
Attachment #526222 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 2

6 years ago
Thanks.

http://hg.mozilla.org/mozilla-central/rev/e94c6b74164f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla6

Comment 3

6 years ago
Do we want this for Aurora?

Updated

6 years ago
tracking-firefox5: --- → ?
What's the risk/reward for taking this? If this is super safe and the reward is high, please nominate the patch.
tracking-firefox5: ? → -

Comment 5

6 years ago
it's super safe. Not sure about reward though, I should know AT internals dor that. Under certain circumstances the deepest child is returned instead the direct child. Marco?

Comment 6

6 years ago
It would account for some inconsistencies I've seen with NVDA. But I've been running with the Nightly for a few days and didn#t notice any difference so far. But I'm nominating it anyway since this will improve things in some instances, and this is a regression introduced in FX4 IIRC.
tracking-firefox5: - → ?

Comment 7

6 years ago
Comment on attachment 526222 [details] [diff] [review]
Patch v1

Nominating the patch, see previous comment.
Attachment #526222 - Flags: approval-mozilla-aurora?

Updated

6 years ago
tracking-firefox5: ? → ---
Comment on attachment 526222 [details] [diff] [review]
Patch v1

Heh. A=me
Attachment #526222 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 9

6 years ago
I took the liberty of landing this on Ms2ger's behalf on Aurora:
http://hg.mozilla.org/mozilla-aurora/rev/389bc8414daf
status-firefox5: --- → fixed

Comment 10

6 years ago
The fix (comparison instead of assignment for the variables aWhichChild and eDeepestChild) is visible in the hg for latest beta build
Setting this as Verified for Firefox 6 Beta:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20100101 Firefox/6.0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.