Closed Bug 650237 Opened 11 years ago Closed 10 years ago

Allow applications to use a symbolic link to the xulrunner-stub instead of a copy

Categories

(Toolkit Graveyard :: XULRunner, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla7

People

(Reporter: glandium, Unassigned)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Attached patch PatchSplinter Review
This is something I have been using for 3 years in Debian, and which avoids copying the stub in each xulrunner application.

The current xulrunner-stub resolves symbolic links first, then checks application.ini in the directory of the stub. The proposed change is to check for application.ini in the directory where the executed program (the symbolic link) is.
Attachment #526223 - Flags: review?(benjamin)
Comment on attachment 526223 [details] [diff] [review]
Patch

I wonder how we can get a test for this...
Attachment #526223 - Flags: review?(benjamin) → review+
(In reply to comment #1)
> Comment on attachment 526223 [details] [diff] [review] [review]
> Patch
> 
> I wonder how we can get a test for this...

How about adding a dummy xulrunner application to the source tree, install it somewhere under dist with the symlink to the stub, and try to start it?
http://hg.mozilla.org/integration/mozilla-inbound/rev/2fda596a9a3f
Flags: in-testsuite?
Whiteboard: [inbound]
(In reply to comment #2)
> (In reply to comment #1)
> > Comment on attachment 526223 [details] [diff] [review] [review] [review]
> > Patch
> > 
> > I wonder how we can get a test for this...
> 
> How about adding a dummy xulrunner application to the source tree, install
> it somewhere under dist with the symlink to the stub, and try to start it?

We do have a simple app here:
http://mxr.mozilla.org/mozilla-central/source/xulrunner/examples/simple/
http://hg.mozilla.org/mozilla-central/rev/2fda596a9a3f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Depends on: 690679
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.