650237 - Allow applications to use a symbolic link to the xulrunner-stub instead of a copy

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Patch

This is something I have been using for 3 years in Debian, and which avoids copying the stub in each xulrunner application.

The current xulrunner-stub resolves symbolic links first, then checks application.ini in the directory of the stub. The proposed change is to check for application.ini in the directory where the executed program (the symbolic link) is.

Comment 1

[Benjamin Smedberg]

Comment on attachment 526223 [details] [diff] [review]
Patch

I wonder how we can get a test for this...

Comment 2

[Mike Hommey [:glandium]]

(In reply to comment #1)
> Comment on attachment 526223 [details] [diff] [review] [review]
> Patch
> 
> I wonder how we can get a test for this...

How about adding a dummy xulrunner application to the source tree, install it somewhere under dist with the symlink to the stub, and try to start it?

Comment 3

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2fda596a9a3f

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> (In reply to comment #1)
> > Comment on attachment 526223 [details] [diff] [review] [review] [review]
> > Patch
> > 
> > I wonder how we can get a test for this...
> 
> How about adding a dummy xulrunner application to the source tree, install
> it somewhere under dist with the symlink to the stub, and try to start it?

We do have a simple app here:
http://mxr.mozilla.org/mozilla-central/source/xulrunner/examples/simple/

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/2fda596a9a3f