The default bug view has changed. See this FAQ.

Build the test plugin on GNU/kfreebsd

RESOLVED FIXED in mozilla6

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla6
All
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 526236 [details] [diff] [review]
Patch

cf. summary
Attachment #526236 - Flags: review?(ted.mielczarek)
Comment on attachment 526236 [details] [diff] [review]
Patch

I think this line is wrong as it stands. The test plugin is widget-toolkit dependent, not OS-dependent:
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/test/testplugin/Makefile.in

so we should change this to be a whitelist of widget toolkits that it supports, which should fix your problem by default, since you're targeting gtk2.
Attachment #526236 - Flags: review?(ted.mielczarek) → review-
Assignee: nobody → mh+mozilla
(Assignee)

Comment 2

6 years ago
Created attachment 526247 [details] [diff] [review]
Patch v2

Completely agreed.
Attachment #526236 - Attachment is obsolete: true
Attachment #526247 - Flags: review?(ted.mielczarek)
Comment on attachment 526247 [details] [diff] [review]
Patch v2

What's OS2's toolkit value? I'm too lazy to look it up. You probably should include that.
Attachment #526247 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

6 years ago
You actually made me look around, and now I'm wondering about qt...
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/mozilla-central/rev/c4b82ec27d6d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
(Assignee)

Comment 6

6 years ago
Created attachment 527739 [details] [diff] [review]
Patch as landed
Attachment #526247 - Attachment is obsolete: true
Attachment #527739 - Flags: review+
You need to log in before you can comment on or make changes to this bug.