Closed
Bug 650263
Opened 13 years ago
Closed 13 years ago
Build the test plugin on GNU/kfreebsd
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla6
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file, 2 obsolete files)
|
590 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
cf. summary
Attachment #526236 -
Flags: review?(ted.mielczarek)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 526236 [details] [diff] [review] Patch I think this line is wrong as it stands. The test plugin is widget-toolkit dependent, not OS-dependent: http://mxr.mozilla.org/mozilla-central/source/modules/plugin/test/testplugin/Makefile.in so we should change this to be a whitelist of widget toolkits that it supports, which should fix your problem by default, since you're targeting gtk2.
Attachment #526236 -
Flags: review?(ted.mielczarek) → review-
|
|
||
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
|
Assignee | |
Comment 2•13 years ago
|
||
Completely agreed.
Attachment #526236 -
Attachment is obsolete: true
Attachment #526247 -
Flags: review?(ted.mielczarek)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 526247 [details] [diff] [review] Patch v2 What's OS2's toolkit value? I'm too lazy to look it up. You probably should include that.
Attachment #526247 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
You actually made me look around, and now I'm wondering about qt...
|
|
Assignee | |
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c4b82ec27d6d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #526247 -
Attachment is obsolete: true
Attachment #527739 -
Flags: review+
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•