release sanity should check that l10n-changesets from L10n dashboard match

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: armenzg, Assigned: catlee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [known release issue], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
If we are doing a normal release we should check that we have taken the L10n changes and if they don't match notify us so we can take action. If it is a chemspill we could pass a parameter to ignore l10n changes.

For example, for 3.6.17 these should match:
https://l10n-stage-sj.mozilla.org/shipping/l10n-changesets?ms=fx3.6.17
http://hg.mozilla.org/build/buildbot-configs/raw-file/FIREFOX_3_6_17_BUILD2/mozilla/l10n-changesets_mozilla-1.9.2
Notice I included the tag as the revision.
Assignee: nobody → astoica
(Reporter)

Updated

8 years ago
Whiteboard: [known release issue]

Comment 1

8 years ago
Note, in the future, the milestone to ship will not exist unless releng actually triggered the data generation piece through "ship it" or "chemspill" (names to change). Also, the data format might convert over to json proper, merging l10n-changesets and shipped-locales.

To go back to https://wiki.mozilla.org/Release:Release_Automation_on_Mercurial/Known_Issues:

Forget about taking L10n changes

    Preempt: We should not allow reviews for releases without L10n changes
    Recover: Cancel every job that is currently running for your release and start with another build #. 

I wonder if there's an api you want on the dashboard for this, or, how to phrase this in a way that works across systems (releng/l10n).

I wouldn't side track chemspills, but try to let them follow the same scheme. I.e., verify that the milestone exists, and that it has the data you expect.

Not sure if you want to check for a difference between the revision in l10n-changesets and the actual built revision in the builds?
(Assignee)

Comment 2

8 years ago
Axel, what we're trying to do right now is to have a simple check that whoever is driving the release has synced up the l10n changesets from the dashboard.

As the dashboard is currently implemented, we can fetch the list from, e.g. https://l10n-stage-sj.mozilla.org/shipping/l10n-changesets?ms=fx3.6.17 and compare against our l10n changesets, right?

It will be up to the releng person doing the release whether to ignore the error if the changesets differ (e.g. for chemspills).

Is "https://l10n-stage-sj.mozilla.org/shipping/l10n-changesets?ms=fx%(version)s" the correct place to look currently?
Created attachment 527666 [details] [diff] [review]
Checks the l10n-changesets against the l10n dashboard

@catlee: let me know if anything needs changing
Attachment #527666 - Flags: review?(catlee)

Comment 4

8 years ago
For context, the current dashboard code is not going to work for the new release model, we need to make some pretty involved changes. I hope to get some progress made on that next week, we're going to have a face-to-face. Those changes are drafted for the data model, but what that means for URLs, not sure yet. That's covered in bug 650816.

https://l10n-stage-sj.mozilla.org/shipping/l10n-changesets?av=fx4.0 might be more stable, though that should turn out wrong for chemspills. Not committing to that URL being stable yet, though.

When milestones move to "create on demand", releng is going to determine the name of the milestone, and you may want to include the build number, to work with "we need to respin for bs" or so.

Verifying that the changesets match doesn't imply that the dashboard got the right knobs hit to not break the next release, too. In particular, there have been a few releases that got the data, but not the final button press.

PS: You should write this code such that it deals gracefully with network errors, to deal with situations like last night, when IT takes down the current setup, and doesn't bring it back up in time.
(Assignee)

Comment 5

8 years ago
Comment on attachment 527666 [details] [diff] [review]
Checks the l10n-changesets against the l10n dashboard

Looks like there are two nearly identical patches here? The first set looks fine.
Attachment #527666 - Flags: review?(catlee) → review+
Created attachment 531914 [details] [diff] [review]
cleaned up previous patch to contain just one diff
Attachment #527666 - Attachment is obsolete: true
Attachment #531914 - Flags: review?(catlee)
Attachment #531914 - Flags: checked-in?
(Assignee)

Updated

8 years ago
Attachment #531914 - Flags: review?(catlee)
Attachment #531914 - Flags: review+
Attachment #531914 - Flags: checked-in?
Attachment #531914 - Flags: checked-in+
(Assignee)

Updated

8 years ago
Assignee: astoica → catlee
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.