@font-face formats do not work without wrapping quotes
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: me, Assigned: jfkthame)
References
Details
Attachments
(3 external files)
| Assignee | ||
Comment 1•15 years ago
|
||
| Reporter | ||
Comment 2•15 years ago
|
||
Comment 3•15 years ago
|
||
Comment 4•5 years ago
|
||
In its most recent form, since July 2018 [1] the CSS Fonts level 4 spec does expect keywords or strings (strings likely for backwards compatibility).
May I nudge this issue? I am working on reliable feature detection for supported font formats and supported font technologies, in that sense arriving at better web compat for the format() stance and the " supports <font-technology>" stance would help a lot. Thanks for considering implementing parsing keywords correctly here and implementing throwing out unsupported entries instead of dropping the src: line as unparseable.
[1] https://github.com/w3c/csswg-drafts/commit/4d3684100754e06cf840a46b7d198df5066902dd
| Assignee | ||
Comment 5•4 years ago
|
||
The CSS Fonts 4 spec requires this, and Safari (at least) has long supported it.
Depends on D154236
Updated•4 years ago
|
| Assignee | ||
Comment 6•4 years ago
|
||
Now that the style system has keywords for this, we don't need to define them in gfx
but can just use the enum directly. (No functional change, just code simplification.)
Depends on D154237
| Assignee | ||
Comment 7•4 years ago
|
||
Depends on D154277
Comment 9•4 years ago
|
||
Backed out for causing reftest failures on variation-format-hint-1a.html
- Backout link
- Push with failures
- Failure Log
- Failure line: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/font-face/variation-format-hint-1a.html == layout/reftests/font-face/variation-format-hint-1A-ref.html | image comparison, max difference: 255, number of differing pixels: 2851
Comment 11•4 years ago
|
||
Comment 12•4 years ago
•
|
||
Backed out for causing wpt failures on format-specifiers-variations.html.
Also please take a look at this Tvw failure.
[task 2022-08-11T19:40:28.010Z] 19:40:28 INFO - TEST-START | /css/css-fonts/format-specifiers-variations.html
[task 2022-08-11T19:40:28.023Z] 19:40:28 INFO - Closing window 0103ec62-616c-493b-954a-33164fc6586c
[task 2022-08-11T19:40:28.378Z] 19:40:28 INFO -
[task 2022-08-11T19:40:28.378Z] 19:40:28 INFO - TEST-PASS | /css/css-fonts/font-variant-alternates-parsing.html | CSS Test: font-variant-alternates: historical-forms; parses case-insensitively
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - TEST-FAIL | /css/css-fonts/font-variation-settings-serialization-001.html | font-feature-settings should be serialized to not include duplicates - assert_in_array: value "\"bldA\" 1, \"bldA\" 2" not in array ["\"bldA\" 2", "'bldA' 2"]
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - @http://web-platform.test:8000/css/css-fonts/font-variation-settings-serialization-001.html:19:32
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2590:25
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - @http://web-platform.test:8000/css/css-fonts/font-variation-settings-serialization-001.html:18:17
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - TEST-PASS | /css/css-fonts/format-specifiers-variations.html | Load Ahem with format woff
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - TEST-PASS | /css/css-fonts/format-specifiers-variations.html | Load Ahem with format truetype
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - TEST-PASS | /css/css-fonts/format-specifiers-variations.html | Load Ahem with format opentype
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - TEST-PASS | /css/css-fonts/format-specifiers-variations.html | Load Ahem with format woff2
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - TEST-PASS | /css/css-fonts/format-specifiers-variations.html | Load Ahem with format woff-variations
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - TEST-PASS | /css/css-fonts/format-specifiers-variations.html | Load Ahem with format truetype-variations
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - TEST-PASS | /css/css-fonts/format-specifiers-variations.html | Load Ahem with format opentype-variations
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - TEST-PASS | /css/css-fonts/format-specifiers-variations.html | Load Ahem with format woff2-variations
[task 2022-08-11T19:40:28.379Z] 19:40:28 INFO - TEST-UNEXPECTED-FAIL | /css/css-fonts/format-specifiers-variations.html | Do not load Ahem with format xyzwoff - assert_unreached: Should have rejected: undefined Reached unreachable code
[task 2022-08-11T19:40:28.380Z] 19:40:28 INFO -
[task 2022-08-11T19:40:28.380Z] 19:40:28 INFO - TEST-UNEXPECTED-FAIL | /css/css-fonts/format-specifiers-variations.html | Do not load Ahem with format xyztruetype - assert_unreached: Should have rejected: undefined Reached unreachable code
[task 2022-08-11T19:40:28.380Z] 19:40:28 INFO -
[task 2022-08-11T19:40:28.380Z] 19:40:28 INFO - TEST-UNEXPECTED-FAIL | /css/css-fonts/format-specifiers-variations.html | Do not load Ahem with format xyzopentype - assert_unreached: Should have rejected: undefined Reached unreachable code
[task 2022-08-11T19:40:28.381Z] 19:40:28 INFO -
[task 2022-08-11T19:40:28.381Z] 19:40:28 INFO - TEST-UNEXPECTED-FAIL | /css/css-fonts/format-specifiers-variations.html | Do not load Ahem with format xyzwoff2 - assert_unreached: Should have rejected: undefined Reached unreachable code
[task 2022-08-11T19:40:28.382Z] 19:40:28 INFO -
[task 2022-08-11T19:40:28.382Z] 19:40:28 INFO - TEST-UNEXPECTED-FAIL | /css/css-fonts/format-specifiers-variations.html | Do not load Ahem with format xyzwoff-variations - assert_unreached: Should have rejected: undefined Reached unreachable code
[task 2022-08-11T19:40:28.383Z] 19:40:28 INFO -
[task 2022-08-11T19:40:28.383Z] 19:40:28 INFO - TEST-UNEXPECTED-FAIL | /css/css-fonts/format-specifiers-variations.html | Do not load Ahem with format xyztruetype-variations - assert_unreached: Should have rejected: undefined Reached unreachable code
[task 2022-08-11T19:40:28.383Z] 19:40:28 INFO -
<...>
[task 2022-08-11T19:40:28.409Z] 19:40:28 INFO - TEST-UNEXPECTED-FAIL | /css/css-fonts/format-specifiers-variations.html | Do not load Ahem with format opentye-variations - assert_unreached: Should have rejected: undefined Reached unreachable code
[task 2022-08-11T19:40:28.409Z] 19:40:28 INFO -
[task 2022-08-11T19:40:28.409Z] 19:40:28 INFO - TEST-UNEXPECTED-FAIL | /css/css-fonts/format-specifiers-variations.html | Do not load Ahem with format woff2variations - assert_unreached: Should have rejected: undefined Reached unreachable code
[task 2022-08-11T19:40:28.493Z] 19:40:28 INFO - TEST-OK | /css/css-fonts/format-specifiers-variations.html | took 482ms
[task 2022-08-11T19:40:29.216Z] 19:40:29 INFO - STDOUT: cleanup aborted: args: /builds/worker/fetches/android-sdk-linux/platform-tools/adb wait-for-device shell rm /data/data/org.mozilla.geckoview.test_runner/files/mozilla/profiles.ini; echo adb_returncode=$?, exitcode: 1, stdout: rm: /data/data/org.mozilla.geckoview.test_runner/files/mozilla/profiles.ini: No such file or directory
[task 2022-08-11T19:40:29.218Z] 19:40:29 INFO - Closing logging queue
[task 2022-08-11T19:40:29.218Z] 19:40:29 INFO - queue closed
[task 2022-08-11T19:40:29.233Z] 19:40:29 INFO - Setting up ssl
[task 2022-08-11T19:40:29.247Z] 19:40:29 INFO - certutil | b''
[task 2022-08-11T19:40:29.265Z] 19:40:29 INFO - certutil | b''
[task 2022-08-11T19:40:29.281Z] 19:40:29 INFO - certutil | b'\nCertificate Nickname Trust Attributes\n SSL,S/MIME,JAR/XPI\n\nweb-platform-tests CT,, \n'
[task 2022-08-11T19:40:34.663Z] 19:40:34 INFO - STDOUT: timed out waiting for profiles.ini
[task 2022-08-11T19:40:34.817Z] 19:40:34 INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test_runner
[task 2022-08-11T19:40:36.399Z] 19:40:36 INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.TestRunnerActivity -a android.intent.action.MAIN --es env0 MOZ_CRASHREPORTER=1 --es env1 MOZ_CRASHREPORTER_NO_REPORT=1 --es env2 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env4 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env6 R_LOG_LEVEL=6 --es env7 R_LOG_DESTINATION=stderr --es env8 R_LOG_VERBOSE=1 --es env9 MOZ_PROCESS_LOG=/tmp/tmpsnjkov21pidlog --es env10 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env11 STYLO_THREADS=1 --es arg0 -no-remote --es arg1 -profile --es arg2 /data/local/tmp/test_root/profile --es arg3 --marionette --es arg4 about:blank --ez use_multiprocess True
[task 2022-08-11T19:40:37.523Z] 19:40:37 INFO - Starting runner
[task 2022-08-11T19:40:38.521Z] 19:40:38 INFO - TEST-START | /css/css-fonts/generic-family-keywords-001.html
Updated•4 years ago
|
Comment 13•4 years ago
|
||
| Assignee | ||
Updated•4 years ago
|
Comment 14•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/db0298f08cc9
https://hg.mozilla.org/mozilla-central/rev/23d26b5f07db
https://hg.mozilla.org/mozilla-central/rev/940492468122
Description
•