650447 - "Advanced" link should show advanced fields

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Mats Palmgren (inactive)]

STEPS TO REPRODUCE
1. go to https://crash-stats.mozilla.com/products/Firefox
2. click the "Advanced" link

ACTUAL RESULTS
https://crash-stats.mozilla.com/query
with "Advanced Filters" hidden

EXPECTED RESULTS
"Advanced Filters" visible, as that is the most common use case

Comment 1

[Nigel Babu [:nigelb]]

Attachment: show advanced query by default

Assigned patch should fix it.  Note, the value is stored in cookies.  May need to clear cookies to see the effect of this patch.

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 549633 [details] [diff] [review]
show advanced query by default

What happens if you get to the search page by using the search box in the upper-right? Haven't had time to test this patch yet but wouldn't the advanced options appear in this case?

Comment 3

[Nigel Babu [:nigelb]]

You're right. Let me figure out how to do this better.

Comment 4

[Schalk Neethling [:espressive]]

So basically, if the URL https://crash-stats.mozilla.com/query is accessed with a parameter ?advanced=1 then the advanced fields are expanded?

Fields visible
https://crash-stats.mozilla.com/query?advanced=1&someparam=somevalue
https://crash-stats.mozilla.com/query?someparam=somevalue&advanced=1

Fields not visible
https://crash-stats.mozilla.com/query?someparam=somevalue

Comment 5

[Schalk Neethling [:espressive]]

Pull request submitted :: https://github.com/mozilla/socorro/pull/113

Comment 6

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/a73a21a61a461d2ccb0ba77d53e51137a08fabee
Merge pull request #113 from ossreleasefeed/advsearch

add url param when user clicks on advanced search... Fixes Bug 650447

Comment 7

[Trif Andrei-Alin[:AlinT]]

Verified on dev and prod!
It seems on stage it's still waiting for the push.