Associate the application with playable media types on Mac

VERIFIED FIXED in Firefox 7

Status

()

Firefox
Shell Integration
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: humph, Assigned: humph)

Tracking

Trunk
Firefox 7
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Firefox can play ogg, oga, ogv, and webm media files, but it doesn't appear as a Recommended Application when you try to open one of these (right-click media file, Open With...).  Chrome does the right thing and provides associations (my Mac currently has Chromium claiming to be the default app for .ogg files, despite me never setting that).  We need to do the same.
(Assignee)

Comment 1

6 years ago
Created attachment 526452 [details] [diff] [review]
Fix

Here's a fix.
Attachment #526452 - Flags: review?(ted.mielczarek)
Comment on attachment 526452 [details] [diff] [review]
Fix

Looks okay to me, but you should probably have a Mac guru sign off on it.
Attachment #526452 - Flags: review?(ted.mielczarek)
Attachment #526452 - Flags: review?(smichaud)
Attachment #526452 - Flags: review+
Comment on attachment 526452 [details] [diff] [review]
Fix

This also looks fine to me ... though I haven't tested it.

Here's Apple's "Information Property List Key Reference":
http://developer.apple.com/library/mac/#documentation/General/Reference/InfoPlistKeyReference/Introduction/Introduction.html

I include it because it's rather hard to find.

And here's the most relevant part of it:
http://developer.apple.com/library/mac/#documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
Attachment #526452 - Flags: review?(smichaud) → review+
(Assignee)

Comment 4

6 years ago
I've tested it, and it works.  I'm assuming with these two r+s I'm good to go?  Setting checkin-needed, please remove if I need another level of review from someone.
Keywords: checkin-needed
patching file browser/app/macbuild/Contents/Info.plist.in
Hunk #1 FAILED at 64
1 out of 1 hunks FAILED -- saving rejects to file browser/app/macbuild/Contents/Info.plist.in.rej
Keywords: checkin-needed
(Assignee)

Comment 6

6 years ago
Created attachment 535726 [details] [diff] [review]
Updated patch, ready for landing
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/056d9d131d5c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7

Comment 8

6 years ago
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110601 Firefox/7.0a1

Verified that Firefox appear as a recommended application when you try to open a video.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.