Closed
Bug 650451
Opened 15 years ago
Closed 15 years ago
Associate the application with playable media types on Mac
Categories
(Firefox :: Shell Integration, defect)
Tracking
()
VERIFIED
FIXED
Firefox 7
People
(Reporter: humph, Assigned: humph)
Details
Attachments
(2 files)
|
1.87 KB,
patch
|
ted
:
review+
smichaud
:
review+
|
Details | Diff | Splinter Review |
|
1.84 KB,
patch
|
Details | Diff | Splinter Review |
Firefox can play ogg, oga, ogv, and webm media files, but it doesn't appear as a Recommended Application when you try to open one of these (right-click media file, Open With...). Chrome does the right thing and provides associations (my Mac currently has Chromium claiming to be the default app for .ogg files, despite me never setting that). We need to do the same.
Comment 2•15 years ago
|
||
Comment on attachment 526452 [details] [diff] [review]
Fix
Looks okay to me, but you should probably have a Mac guru sign off on it.
Attachment #526452 -
Flags: review?(ted.mielczarek)
Attachment #526452 -
Flags: review?(smichaud)
Attachment #526452 -
Flags: review+
Comment 3•15 years ago
|
||
Comment on attachment 526452 [details] [diff] [review]
Fix
This also looks fine to me ... though I haven't tested it.
Here's Apple's "Information Property List Key Reference":
http://developer.apple.com/library/mac/#documentation/General/Reference/InfoPlistKeyReference/Introduction/Introduction.html
I include it because it's rather hard to find.
And here's the most relevant part of it:
http://developer.apple.com/library/mac/#documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
Attachment #526452 -
Flags: review?(smichaud) → review+
| Assignee | ||
Comment 4•15 years ago
|
||
I've tested it, and it works. I'm assuming with these two r+s I'm good to go? Setting checkin-needed, please remove if I need another level of review from someone.
Keywords: checkin-needed
Comment 5•15 years ago
|
||
patching file browser/app/macbuild/Contents/Info.plist.in
Hunk #1 FAILED at 64
1 out of 1 hunks FAILED -- saving rejects to file browser/app/macbuild/Contents/Info.plist.in.rej
Keywords: checkin-needed
| Assignee | ||
Comment 6•15 years ago
|
||
| Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Comment 8•15 years ago
|
||
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110601 Firefox/7.0a1
Verified that Firefox appear as a recommended application when you try to open a video.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•