650508 - [Windows] mochitest and reftest suites report "leaked 1 instance of Mutex with size 12 bytes" now

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Serge Gautherie (:sgautherie)]

http://build.mozillamessaging.com/tinderboxpushlog/?tree=SeaMonkey&rev=a51304869f50
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1301653893.1301655081.3265.gz
WINNT 5.2 comm-central-trunk debug test crashtest on 2011/04/01 03:31:33
http://hg.mozilla.org/comm-central/rev/a51304869f50
http://hg.mozilla.org/mozilla-central/rev/943bf5a2714c
was fine.

http://build.mozillamessaging.com/tinderboxpushlog/?tree=SeaMonkey&rev=283cf841daac
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1302210301.1302211361.16398.gz
WINNT 5.2 comm-central-trunk debug test crashtest on 2011/04/07 14:05:01
http://hg.mozilla.org/comm-central/rev/283cf841daac
http://hg.mozilla.org/mozilla-central/rev/fb566937c787
{
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 12 bytes during test execution
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of Mutex with size 12 bytes
}

(1 week) Regression timeframes:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=943bf5a2714c&tochange=fb566937c787
http://hg.mozilla.org/comm-central/pushloghtml?fromchange=a51304869f50&tochange=283cf841daac

Comment 1

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> http://hg.mozilla.org/comm-central/pushloghtml?fromchange=a51304869f50&tochange=283cf841daac

That could likely be bug 647000 and/or bug 647003.
Ah, very likely bug 647000 comment 36...
{
/mailnews/addrbook/src/nsAbWinHelper.h
    * line 45 -- #include "mozilla/Mutex.h"
    * line 133 -- static mozilla::Mutex mMutex ;
}

Fwiw, this bug doesn't seem to affect SeaMonkey 2.1. I'm not sure why.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Looks like this is also happening on mozilla-central.

s: talos-r3-xp-045
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 12 bytes during test execution
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of Mutex with size 12 bytes

Comment 3

[Matt Woodrow (:mattwoodrow)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1306109957.1306112576.6462.gz#err0

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
(In reply to comment #3)

'regressionwindow-wanted' for that Firefox leak.
Firefox isn't building MailNews. Did you actually mean that there is an underlying Core bug?

Comment 5

[David :Bienvenu]

I'd like to see this fixed to clean up our leak logs, so I more easily tell that I'm not adding leaks.

Comment 6

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Filed bug 668086 for the random case on mozilla-central

Comment 7

[David :Bienvenu]

Attachment: fix mutex leak

this gets rid of the static Mutex in favor of using an nsAutoPtr to an allocated Mutex that's freed when our use count goes to zero. This does fix the test leak, and I believe it should work fine when the abWinHelper code is actually used, but I need to verify that.

Comment 8

[David :Bienvenu]

Comment on attachment 542897 [details] [diff] [review]
fix mutex leak

fallout from the recent mutex changes - this removes the alleged leak from our leakstats.

Comment 9

[David :Bienvenu]

fixed on trunk - http://hg.mozilla.org/comm-central/rev/f03b17b338ef