Last Comment Bug 650526 - Follow up to Bug 648102, changes to JS_BufferIsCompilableUnit
: Follow up to Bug 648102, changes to JS_BufferIsCompilableUnit
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: general
:
Mentors:
Depends on:
Blocks: 648102
  Show dependency treegraph
 
Reported: 2011-04-16 12:01 PDT by Wesley W. Garland
Modified: 2011-04-16 14:49 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Set existing calls to behave the way they used to (2.00 KB, patch)
2011-04-16 12:01 PDT, Wesley W. Garland
gal: review+
Details | Diff | Splinter Review

Description Wesley W. Garland 2011-04-16 12:01:59 PDT
Created attachment 526506 [details] [diff] [review]
Set existing calls to behave the way they used to

Bug 648102 missed two call sites, and the tree is now red.
Comment 1 Andreas Gal :gal 2011-04-16 12:07:55 PDT
Comment on attachment 526506 [details] [diff] [review]
Set existing calls to behave the way they used to

Changing APIs always bites you ..., next time feel free to land and then get review retroactively.
Comment 2 Wesley W. Garland 2011-04-16 13:29:39 PDT
Thanks, Andreas!

I was just trying to make sure my knuckles stay as far away from the wooden ruler as possible. ;)   ... either way, I wouldn't have walked away on a red tree, although I probably would have backed out if I couldn't find a peer fast enough.
Comment 3 Wesley W. Garland 2011-04-16 14:49:54 PDT
The tree is green (enough)

Note You need to log in before you can comment on or make changes to this bug.