The default bug view has changed. See this FAQ.

Follow up to Bug 648102, changes to JS_BufferIsCompilableUnit

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Wesley W. Garland, Unassigned)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 526506 [details] [diff] [review]
Set existing calls to behave the way they used to

Bug 648102 missed two call sites, and the tree is now red.
Attachment #526506 - Flags: review?(gal)

Comment 1

6 years ago
Comment on attachment 526506 [details] [diff] [review]
Set existing calls to behave the way they used to

Changing APIs always bites you ..., next time feel free to land and then get review retroactively.
Attachment #526506 - Flags: review?(gal) → review+
(Reporter)

Comment 2

6 years ago
Thanks, Andreas!

I was just trying to make sure my knuckles stay as far away from the wooden ruler as possible. ;)   ... either way, I wouldn't have walked away on a red tree, although I probably would have backed out if I couldn't find a peer fast enough.
Blocks: 648102
(Reporter)

Comment 3

6 years ago
The tree is green (enough)
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.