Closed Bug 650526 Opened 10 years ago Closed 10 years ago

Follow up to Bug 648102, changes to JS_BufferIsCompilableUnit

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: wes, Unassigned)

References

Details

Attachments

(1 file)

Bug 648102 missed two call sites, and the tree is now red.
Attachment #526506 - Flags: review?(gal)
Comment on attachment 526506 [details] [diff] [review]
Set existing calls to behave the way they used to

Changing APIs always bites you ..., next time feel free to land and then get review retroactively.
Attachment #526506 - Flags: review?(gal) → review+
Thanks, Andreas!

I was just trying to make sure my knuckles stay as far away from the wooden ruler as possible. ;)   ... either way, I wouldn't have walked away on a red tree, although I probably would have backed out if I couldn't find a peer fast enough.
Blocks: 648102
The tree is green (enough)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.