Closed
Bug 650534
Opened 13 years ago
Closed 10 years ago
[READY] test_websocket.html uses flaky timeouts, and it should be annotated as such
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.61 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This tests uses magic timeout values in a very bad way. I don't see an obvious fix, so for now, it should use the annotation API added in bug 649012. The forcegc timeout value of 1, though, should really be 0, since they will both get clamped up to the same number (currently 4ms) anyways. I have a patch which does these two things.
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Comment 2•13 years ago
|
||
Comment on attachment 526510 [details] [diff] [review] Patch (v1) Though, I'm not sure if the tests are really that fragile. There has been some work to try to make tests not fail.
Attachment #526510 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Updated•13 years ago
|
Summary: test_websocket.html uses flaky timeouts, and it should be annotated as such → [READY] test_websocket.html uses flaky timeouts, and it should be annotated as such
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3d6ef72fd8
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1b3d6ef72fd8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•