Closed
Bug 650543
Opened 15 years ago
Closed 15 years ago
Rewrite the test for bug 419132 to make it sane, and re-enable it
Categories
(Core :: XBL, defect)
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
2.73 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
The test for bug 419132 tries to reload the window in an infinite loop, with a 60 second timeout. This is crazy, and the test has been disabled because of this (rightly so).
I have a patch which makes the test load 4 times, and then finishes. Technically, two times should be enough (since the original test case needs to trigger the gc, which will happen some time in the future tests), but I decided to cut it some slack!
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #526512 -
Flags: review?(jonas)
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Comment on attachment 526512 [details] [diff] [review]
Patch (v1)
Could you also trigger a GC after every other load? There's code in the patch in bug 588990 which adds API to SpecialPowers to trigger a GC. Feel free to steal the implementation from there you also review it (not the whole patch, just the gc implementation).
r=me with that.
Attachment #526512 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•