Rewrite the test for bug 419132 to make it sane, and re-enable it

RESOLVED FIXED in mozilla6

Status

()

Core
XBL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla6
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The test for bug 419132 tries to reload the window in an infinite loop, with a 60 second timeout.  This is crazy, and the test has been disabled because of this (rightly so).

I have a patch which makes the test load 4 times, and then finishes.  Technically, two times should be enough (since the original test case needs to trigger the gc, which will happen some time in the future tests), but I decided to cut it some slack!
Created attachment 526512 [details] [diff] [review]
Patch (v1)
Attachment #526512 - Flags: review?(jonas)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Blocks: 419132
Comment on attachment 526512 [details] [diff] [review]
Patch (v1)

Could you also trigger a GC after every other load? There's code in the patch in bug 588990 which adds API to SpecialPowers to trigger a GC. Feel free to steal the implementation from there you also review it (not the whole patch, just the gc implementation).

r=me with that.
Attachment #526512 - Flags: review?(jonas) → review+
http://hg.mozilla.org/mozilla-central/rev/bde0207d4168
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.