650572 - "ASSERTION: editor cannot get selection"

Status: RESOLVED WORKSFORME

(Core :: DOM: Editor, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: editor cannot get selection: 'selection', file editor/libeditor/text/nsTextEditRules.cpp, line 146

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Jesse Ruderman]

Ehsan, maybe you can help me figure out why this testcase needs a timeout? ;)

Comment 3

[Jesse Ruderman]

Attachment: testcase

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I can't reproduce this, but my guess would be that you don't need a timeout per se, you just need to spin the event loop some amount.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Actually, I can reproduce this if I run it from bmo and not locally.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Alternative stack

My stack is a bit different

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This is a regression.

http://hg.mozilla.org/mozilla-central/rev/54d00e3411ab caused this testcase to crash with the following stack:

#0  0x00007ffff65be765 in nsEditor::Init (this=0x7fffe028bde0, aDoc=
    0x7fffdf5c1978, aPresShell=0x7fffdf7c6800, aRoot=0x0, aSelCon=0x0,
    aFlags=<value optimized out>)
    at /home/khuey/dev/mozilla-central/editor/libeditor/base/nsEditor.cpp:260
#1  0x00007ffff65ae882 in nsPlaintextEditor::Init (this=0x7fffe028bde0, aDoc=
    0x7fffdf5c1978, aPresShell=0x7fffdf7c6800, aRoot=<value optimized out>,
    aSelCon=<value optimized out>, aFlags=<value optimized out>)
    at /home/khuey/dev/mozilla-central/editor/libeditor/text/nsPlaintextEditor.c
pp:157
#2  0x00007ffff63fd900 in nsTextEditorState::PrepareEditor (this=
    0x7fffdf9a9780, aValue=0x0)
    at /home/khuey/dev/mozilla-central/content/html/content/src/nsTextEditorStat
e.cpp:1205
#3  0x00007ffff63ff445 in PrepareEditorEvent::Run (this=<value optimized out>)
    at /home/khuey/dev/mozilla-central/content/html/content/src/nsTextEditorStat
e.cpp:1036
#4  0x00007ffff630a3b2 in nsContentUtils::RemoveScriptBlocker ()
    at /home/khuey/dev/mozilla-central/content/base/src/nsContentUtils.cpp:4753
#5  0x00007ffff613b2ec in nsAutoScriptBlocker::~nsAutoScriptBlocker (
    this=<value optimized out>, __in_chrg=<value optimized out>)
    at ../../dist/include/nsContentUtils.h:1892
#6  0x00007ffff618254e in PresShell::FlushPendingNotifications (this=
    0x7fffdf7c6800, aType=Flush_InterruptibleLayout)
    at /home/khuey/dev/mozilla-central/layout/base/nsPresShell.cpp:4849

I'll bisect for when the crash became an assert when I have more time.

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

And it went from a crash to an assert somewhere in the changesets from Bug 407127.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Testcase no longer asserts on trunk.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/afa1cf0524f7

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afa1cf0524f7

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/afa1cf0524f7