650578 - browser_addons tests is not designed for Android notifications

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

browser_addons.js has explicit tests for toaster alert style popups. On Android, we don't use toaster alerts, we use native alerts. We need to update the tests to handle native alerts or conditionally remove the toaster alert tests.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: disable for now

One part pursuit of green, one part suspicion that some of the other failures are the result of a previous timeout leaving the browser in an unexpected state that later tests aren't cleaning up before they start.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

this patch looks fine to me.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

This should fix the failure. Things look fine on Desktop (need to add the patch in bug 650123 which I need to push). Not sure how to test on device.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 526783 [details] [diff] [review]
Patch


>-  waitFor(doTest, function() { return AlertsHelper.container.hidden == false; });
>+  let sysInfo = Cc["@mozilla.org/system-info;1"].getService(Ci.nsIPropertyBag2);
>+  gDevice = sysInfo.get("device");
>+  if (gDevice != null)

gDevice is not declared, but let's just drop it anyway.

if (sysInfo.get("device") != null)

Comment 5

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/mozilla-central/rev/5be1192ae378

Comment 6

[Anna (Waverley)]

VERIFIED FIXED on:

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110524 Firefox/6.0a1 Fennec/6.0a1 

Device: HTC Desire Z (Android 2.2)

Comment 7

[Dão Gottwald [:dao]]

bugspam