Test for bug 500328 should avoid using flaky timeouts

RESOLVED FIXED in mozilla6

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla6
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 526552 [details] [diff] [review]
Patch (v1)
Attachment #526552 - Flags: review?(jonas)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
I'm not even sure why that longWait is there, to be perfectly honest.  Presumably it doesn't work with setTimeout(0).  But if the idiom you replaced it with is useful, then maybe it belongs in SimpleTest?

Thanks for taking on this project, Ehsan.
(In reply to comment #2)
> I'm not even sure why that longWait is there, to be perfectly honest. 
> Presumably it doesn't work with setTimeout(0).

This is used to test to make sure that something doesn't happen.  Depending on the number of events that need to be processed for that thing to happen (in a buggy situation), setTimeout(0) might not work.

>  But if the idiom you replaced
> it with is useful, then maybe it belongs in SimpleTest?

Maybe.  I've used this idiom in a bunch of places so far.  But I think this is something that can easily be done if needed later.  At this point, I don't want to worry about abstracting these types of idioms into SimpleTest functions.

> Thanks for taking on this project, Ehsan.

No problem!  Any help is appreciated BTW.  :-)
Attachment #526552 - Flags: review?(jonas) → review+
http://hg.mozilla.org/mozilla-central/rev/2e7baa194d4f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.