Closed
Bug 650583
Opened 14 years ago
Closed 14 years ago
test_postMessage_special.xhtml should not try to duplicate the test harness timeout detection code
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
4.66 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
Reading this test made me cry for about 10 minutes.
This test is attempting to inject its own timeout detection mechanism to catch the cases where the postMessage API is not accessible in an iframe.
However, timeout is a valid failure state for a test, and our test harness is quite capable of catching such timeout cases, so that we wouldn't need every single test to come up with its own timeout detection solution.
This test should just stop trying to be smart, and start playing well with our test framework.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #526554 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•