Closed Bug 650583 Opened 9 years ago Closed 9 years ago

test_postMessage_special.xhtml should not try to duplicate the test harness timeout detection code

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

Reading this test made me cry for about 10 minutes.

This test is attempting to inject its own timeout detection mechanism to catch the cases where the postMessage API is not accessible in an iframe.

However, timeout is a valid failure state for a test, and our test harness is quite capable of catching such timeout cases, so that we wouldn't need every single test to come up with its own timeout detection solution.

This test should just stop trying to be smart, and start playing well with our test framework.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #526554 - Flags: review?(jonas)
http://hg.mozilla.org/mozilla-central/rev/62bee8433617
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.