test_postMessage_special.xhtml should not try to duplicate the test harness timeout detection code

RESOLVED FIXED in mozilla6

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla6
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reading this test made me cry for about 10 minutes.

This test is attempting to inject its own timeout detection mechanism to catch the cases where the postMessage API is not accessible in an iframe.

However, timeout is a valid failure state for a test, and our test harness is quite capable of catching such timeout cases, so that we wouldn't need every single test to come up with its own timeout detection solution.

This test should just stop trying to be smart, and start playing well with our test framework.
Created attachment 526554 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #526554 - Flags: review?(jonas)
Attachment #526554 - Flags: review?(jonas) → review+
http://hg.mozilla.org/mozilla-central/rev/62bee8433617
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.