Last Comment Bug 650583 - test_postMessage_special.xhtml should not try to duplicate the test harness timeout detection code
: test_postMessage_special.xhtml should not try to duplicate the test harness t...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla6
Assigned To: :Ehsan Akhgari (away Aug 1-5)
:
Mentors:
Depends on:
Blocks: FlakyTimeout
  Show dependency treegraph
 
Reported: 2011-04-16 20:40 PDT by :Ehsan Akhgari (away Aug 1-5)
Modified: 2011-04-26 13:41 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (4.66 KB, patch)
2011-04-16 20:41 PDT, :Ehsan Akhgari (away Aug 1-5)
jonas: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari (away Aug 1-5) 2011-04-16 20:40:54 PDT
Reading this test made me cry for about 10 minutes.

This test is attempting to inject its own timeout detection mechanism to catch the cases where the postMessage API is not accessible in an iframe.

However, timeout is a valid failure state for a test, and our test harness is quite capable of catching such timeout cases, so that we wouldn't need every single test to come up with its own timeout detection solution.

This test should just stop trying to be smart, and start playing well with our test framework.
Comment 1 :Ehsan Akhgari (away Aug 1-5) 2011-04-16 20:41:34 PDT
Created attachment 526554 [details] [diff] [review]
Patch (v1)
Comment 2 :Ehsan Akhgari (away Aug 1-5) 2011-04-26 13:41:11 PDT
http://hg.mozilla.org/mozilla-central/rev/62bee8433617

Note You need to log in before you can comment on or make changes to this bug.