650684 - browser_awesomescreen.js times out after "urlbar text should be selected on a double click"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Phil Ringnalda (:philor)]

Appears to be an actual specific failure, rather than just a matter of time, since every one I looked at timed out in the same place, somewhere between http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/tests/browser_awesomescreen.js#279 and the next thing that would output something, and in a waitFor timeout that seems likely to mean that "Browser.tabs.length == 1" never happens.

TEST-PASS | chrome://mochitests/content/browser/mobile/chrome/browser_awesomescreen.js | urlbar text should be selected on a double click
TEST-INFO | chrome://mochitests/content/browser/mobile/chrome/browser_awesomescreen.js | Console message: [JavaScript Error: "uncaught exception: waitFor timeout"]
NEXT ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/mobile/chrome/browser_awesomescreen.js | Test timed out
INFO TEST-END | chrome://mochitests/content/browser/mobile/chrome/browser_awesomescreen.js | finished in 30001ms

Knowing nothing at all about it, two possibilities occur to me: it needs to closeTab(this._currentTab, { forceClose: true }) the way other things do, or, if it depends on Browser.tabs.length + 1 - 1 == 1, it needs to explicitly do so by testing is(Browser.tabs.length, 1, "who left a tab open?") before it opens its tab.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

I'm pretty sure that trying to close this._currentTab which is undefined (the function is inside a setTimeout) does not close it :)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mozilla-central/rev/6a30a51ecc31

Comment 3

[Andreea Pod]

Is there a way for us to verify this?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #3)
> Is there a way for us to verify this?

The good way to check for this is to go to:
http://tbpl.mozilla.org/?tree=Mobile&noignore=1

If the results name 'b-c' is orange (likely) you can click on it, wait a bit, and then click on 'show brief log' on the left bottom corner. You will see the reasons why the test is orange, if you don't see this line it means this bug can be marked as verified.

Don't hesitate to ping me if you need further assistance.

Comment 5

[Andreea Pod]

Thank you Vivien. 

Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110508 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2)

Comment 6

[Dão Gottwald [:dao]]

bugspam