Confirmed with Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110419 Firefox/6.0a1 ID:20110419030537. Would be nice to know when this regressed. http://harthur.github.com/mozregression/
Is this a matter of the link being clickable after the old window has stopped being the current inner window for the outer? Olli, do we still deliver mouse events to the old page at that point, while the new page is being paint-suppressed?
We do deliver mouse events to the old page, but not actually call event listeners, but postHandleEvent is called. That is a known, old bug (although the bug was filed recently) and was present even in 3.0, AFAIK. This one seems to be something recent. Reporter, when you say Firefox3, do you actually mean Firefox 3.6?
Yes, Firefox3 = Firefox 3.6.13
I've tracked down a regression range using GNU/Linux. My gut feeling is that it may be easier to make recent versions freak out, but it's hard to find a regression range for that since now and then one has luck and makes even harder-to-reproduce versions screw up within a few clicks. Last good nightly: 2009-04-13 First bad nightly: 2009-04-14 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=68cfe7fb9f31&tochange=398bc50386b7 The first bad revision is: changeset: 27266:cf28ca744768 user: Boris Zbarsky <firstname.lastname@example.org> date: Mon Apr 13 11:33:27 2009 -0400 summary: Bug 485643. Remove some unnecessary code, r+sr=jst http://hg.mozilla.org/mozilla-central/rev/cf28ca744768
Though if we're calling PostHandleEvent, then we could be zombie even by the time OnLinkClick is called... The problem with enforcing the same document in OnLinkClick and OnLinkClickSync, by the way, is that it's not clear to me whether this would break sites. I'll need to do some experimenting on that. In an ideal world, we'd just stash the inner window to run against in OnLinkClick or something, but there's no really good way to do that at the moment.
Created attachment 541593 [details] [diff] [review] Possible fix
I get an HTTP 404 when trying to access http://libardo.com/moz/HTMLPage1.aspx. Do we still have a testcase around?
Verified as fixed on: Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:7.0) Gecko/20100101 Firefox/7.0 Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0 Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0 + Aurora (Fx 8.0a2) & Nightly (Fx 9.0a1). STR: 1. Loaded http://libardo.com/moz/HTMLPage1.aspx in a Fx tab. 2. Clicked the link multiple time very fast. Everything worked fine. No "Not ... was ..." text was displayed.