650830 - Error: charset.trim is not a function in ja locale, changing character encoding on about:firefox

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

With the Maemo Japanese locale build of Firefox4.0.1 (build 1) candidate, I'm seeing these js error in the console, when changing the character encoding on about:firefox.

charset.trim is not a function
chrome://browser/content/common-ui.js
1430
currentCharset.trim is not a function
chrome://browser/content/common-ui.js
1473

Steps to reproduce:
- Go to about:firefox
- Click on the icon in the url bar, choose the character encoding entry (I know, it's japanese)
- Choose one of the available options.

I haven't tested this on trunk yet, nor on Android, using the japanese build.

Comment 1

[Martijn Wargers (dead)]

Ok, I can see this on a 4/12 trunk build on Android too (using Droid), using the US locale.
A little bit different steps to reproduce, though:
- You have to have "Show Character Encoding" enabled in the prefs (in options)
- go to about:firefox
- Tap on the icon in the url bar, tap on Character Encoding entry
- Choose one of the options.
- Tap on the icon in the url bar again.

In this case I'm only seeing the "charset.trim is not a function" error.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Whoops. forcedCharset actually returns an nsIAtom, but for remote tabs I am being tricky and actually returning a string. For local tabs, we get the nsIAtom.

This just calls toString on the charset so that it will work regardless of what is returned.

Comment 3

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/mozilla-central/rev/725ea124833d

Comment 4

[Andreea Pod]

Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110508 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2)