650882 - port hgtool to mozharness

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect, P4)

Description

[Aki Sasaki (not active)]

This should make mozharness' mercurial actions standardized and more robust.

Comment 2

[Aki Sasaki (not active)]

* port hgtool in a completely backwards compatible way
* port hgtool to work naturally in the mozharness framework
* port hgtool with an eye towards clean and maintainable code

Right now it's looking like we need to choose two.
I'm thinking about the latter two... keep the same functionality but break some direct hgtool/util.hg backwards compatibility.

Comment 3

[Aki Sasaki (not active)]

http://hg.mozilla.org/users/asasaki_mozilla.com/talosrunner/file/4d1db9f026c2/scripts/sourcetool.py works!

./scripts/sourcetool.py http://hg.mozilla.org/build/buildbotcustom gave me a buildbotcustom and an hg revision.

However, I think mozharness.base.vcs.mercurial.MercurialVCS needs lots of work (see comment 2).

http://hg.mozilla.org/users/asasaki_mozilla.com/talosrunner/file/4d1db9f026c2/mozharness/base/vcs/mercurial.py#l84

Comment 4

[Aki Sasaki (not active)]

Attachment: huge diff; working hgtool.py

The diff is probably too large to be helpful.
This is basically an |hg diff -r default| from the tip of the 0.4-devel branch in my talosrunner user repo.  It may be easiest to look at the source:

http://hg.mozilla.org/users/asasaki_mozilla.com/talosrunner/file/896b5368ad7d/scripts/sourcetool.py

I was able to successfully:

 scripts/hgtool.py http://hg.mozilla.org/build/buildbotcustom ../foo

and

 scripts/hgtool.py -s ~/src/clean/buildbotcustom http://hg.mozilla.org/build/buildbotcustom ../foo

Comment 5

[Aki Sasaki (not active)]

All unit tests from build/tools/lib/python/buildtools/test/test_util_hg.py are ported as of http://hg.mozilla.org/users/asasaki_mozilla.com/talosrunner/rev/36e76a3e6fd9 .

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 528768 [details] [diff] [review]
huge diff; working hgtool.py

Some nits:
* as you said in the comments it would be better to remove env variables
* url = "%s/rev/%s" % (c['vcs_repo'], got_revision) looks HG specific, probably you may want to wrap it in the future, something like vcs.get_url(...)
* vcs or scm? :p

BTW, there are a lot of functions from build/tools. We need to switch to mozharness to prevent more divergence in the future.

Comment 7

[Aki Sasaki (not active)]

hgtool-in-mozharness will be landing as part of the 0.4 landing (bug 651974).