The default bug view has changed. See this FAQ.

UrlCryptoKeyManager does not correctly translate base64 keys

RESOLVED FIXED in Firefox 20

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: mmm, Assigned: Nikolay Bryskin)

Tracking

Trunk
Firefox 20
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In unUrlSafe, we only translate the first instance of a "-" -> "+" and "_" -> "/". These replacements should be made global.

Appropriate section of code:
http://hg.mozilla.org/mozilla-central/diff/39d0829ed9e2/toolkit/components/url-classifier/content/url-crypto-key-manager.js

It looks like this piece of code is still used, not 100% sure though. Basing my judgement that this should be a global replace on the nsUrlClassifierUtils version at http://mxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierUtils.cpp#401
(Assignee)

Comment 1

6 years ago
Created attachment 554277 [details] [diff] [review]
UnUrlSafe fix

Hi, here is the fix for this bug
Attachment #554277 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #554277 - Flags: review?(dcamp) → review+

Comment 2

4 years ago
Hello Nikolay, do you require assistance in getting this patch checked-in to the tree?
Assignee: nobody → devel.niks
Status: NEW → ASSIGNED
Flags: needinfo?(devel.niks)
(Assignee)

Comment 3

4 years ago
Yep, I think so. It emerged that it's more complicated process than I thought.
Flags: needinfo?(devel.niks)

Comment 4

4 years ago
>> Hello Nikolay, do you require assistance in getting this patch checked-in to the tree?
> Yep, I think so. It emerged that it's more complicated process than I thought.
Setting the checkin-needed flag.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef515efc6ff7

Thanks for the patch, Nikolay! And sorry for the horribly long delay :(
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ef515efc6ff7
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.