650935 - UrlCryptoKeyManager does not correctly translate base64 keys

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Mehdi Mulani [:mmm] (I don't check this)]

In unUrlSafe, we only translate the first instance of a "-" -> "+" and "_" -> "/". These replacements should be made global.

Appropriate section of code:
http://hg.mozilla.org/mozilla-central/diff/39d0829ed9e2/toolkit/components/url-classifier/content/url-crypto-key-manager.js

It looks like this piece of code is still used, not 100% sure though. Basing my judgement that this should be a global replace on the nsUrlClassifierUtils version at http://mxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierUtils.cpp#401

Comment 1

[Nikolay Bryskin]

Attachment: UnUrlSafe fix

Hi, here is the fix for this bug

Comment 2

[Philip Chee]

Hello Nikolay, do you require assistance in getting this patch checked-in to the tree?

Comment 3

[Nikolay Bryskin]

Yep, I think so. It emerged that it's more complicated process than I thought.

Comment 4

[Philip Chee]

>> Hello Nikolay, do you require assistance in getting this patch checked-in to the tree?
> Yep, I think so. It emerged that it's more complicated process than I thought.
Setting the checkin-needed flag.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef515efc6ff7

Thanks for the patch, Nikolay! And sorry for the horribly long delay :(

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ef515efc6ff7