65100 - [BeOS: Copy & Paste] implement nsClipboard

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Takashi Toyoshima]

Currently nsClipboard for BeOS is not implemented. 
And now I'm implementing it. :)

Comment 1

[Takashi Toyoshima]

Attachment: copy'n paste of text/unicode implemented

Comment 2

[Takashi Toyoshima]

Now copy'n paste of text/unicode in SetNativeClipboardData and GetNativeClipboardData
were implemented. But not text/html.
And in SetNativeClipboardData, we get always null data from mTransferable for any reason.
So copy operation can not work currently.

Comment 3

[Makoto Hamanaka]

Hi toyoshima,
because it has not checked in to CVS tree, it should not be RESOLVED/FIXED.

reopen this bug.
cc: me, cls, yannick
change severity to major.

Comment 4

[Takashi Toyoshima]

Attachment: new version (no need for "01/11/01 14:08" diffs)

Comment 5

[Takashi Toyoshima]

Thank you for advices, Makoto!

I fixed implementation again.
(using text conversion function in nsString)

reassign to cls.

Comment 6

[Takashi Toyoshima]

Attachment: please forget previous diff ;-)

Comment 7

[timeless]

!     if ((B_OK == rc) && (NULL != data) && (0 != size)) {

1. someone doesn't like (const comparison variable) but that's kind of style.
2. you don't need ()s around those
3. please use nsnull over NULL
4. i prefer (size) over (size != 0) and (data) over (data != nsnull)

!   BMessage *msg;
!   nsresult rv = NS_ERROR_FAILURE;
! 
!   if (NULL != (msg = be_clipboard->Data())) {
why not:
!   BMessage *msg=be_clipboard->Data();
!   nsresult rv = NS_ERROR_FAILURE;
! 
!   if (msg) {

i'll try to attach a version based on these styles 

Comment 8

[timeless]

Attachment: revised patch, cvs diff -u

Comment 9

[cls]

I checked in a modified version of attach 22447.  The reason mTransferable
seemed to be always returning null was because you were never calling
nsPrimitive:CreateDataFromPrimitive() so the clipboard data was never being
assigned to your data variable. 

Thanks for the patch.  I'm leaving the bug open until nsClipboard is fully
implemented.

Comment 10

[Takashi Toyoshima]

Attachment: patch for full feature :)

Comment 11

[Takashi Toyoshima]

Thank you cls and timeless.
I made new patch.

This patch contain following.
1. fix of some mistaken coding styles.
2. bug fix (sometimes copyed string was broken.)
3. 'copy link location' work. (I delete QueryInterface().)
4. copy'n paste of text/html and others.

Comment 12

[Takashi Toyoshima]

Attachment: revised patch

Comment 13

[Takashi Toyoshima]

22879 is revised of 22865.
22865 contain a bug that we can not copy from text box.

Comment 14

[Takashi Toyoshima]

Attachment: sorry... revised of 22879 (22879 has problem of paste on composer)

Comment 15

[kurros (Wade Majors)]

note: 22882 updates the nsClipboard.cpp part of 22879, but does not include the 
nsClipboard.h changes.

Comment 16

[cls]

Checked in nsClipboard.h changes from attach 22879 and nsClipboard.cpp changes
from attach 22882.  Marking fixed.

Comment 17

[Kai Lahmann (is there, where MNG is)]

v