Closed
Bug 651013
Opened 13 years ago
Closed 13 years ago
a couple of layout/base mochitests should be moved to mochitest-chrome tests
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
Details
(Whiteboard: [specialpowers])
Attachments
(1 file, 1 obsolete file)
|
4.54 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
in trying to get the layout/base/tests/test_* mochitests running with only specialPowers, I noticed that a couple test files were doing things that should really belong in mochitest-chrome: - test_bug370436.html - test_bug420499.xul In addition there are some reftest style tests in test_reftests_with_caret.html which I am not sure should be in mochitest-plain.
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [specialpowers]
|
|
Assignee | |
Comment 1•13 years ago
|
||
simple patch to move some tests from mochitest plain to chrome.
Assignee: nobody → jmaher
Attachment #526898 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 526898 [details] [diff] [review] move two test files -> chrome tests (1.0) I think for moving tests to chrome you should get review from the original test author or reviewer, since they have the subject knowledge here.
Attachment #526898 -
Flags: review?(ted.mielczarek) → review?(roc)
This patch should use hg rename.
|
|
Assignee | |
Comment 4•13 years ago
|
||
updated with hg rename vs hg delete/add
Attachment #526898 -
Attachment is obsolete: true
Attachment #526898 -
Flags: review?(roc)
Attachment #527180 -
Flags: review?(roc)
Comment on attachment 527180 [details] [diff] [review] move two test files -> chrome tests (2.0) Thanks!
Attachment #527180 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=f6677d8c32fc
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•