651013 - a couple of layout/base mochitests should be moved to mochitest-chrome tests

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in trying to get the layout/base/tests/test_* mochitests running with only specialPowers, I noticed that a couple test files were doing things that should really belong in mochitest-chrome:
 - test_bug370436.html
 - test_bug420499.xul

In addition there are some reftest style tests in test_reftests_with_caret.html which I am not sure should be in mochitest-plain.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: move two test files -> chrome tests (1.0)

simple patch to move some tests from mochitest plain to chrome.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 526898 [details] [diff] [review]
move two test files -> chrome tests (1.0)

I think for moving tests to chrome you should get review from the original test author or reviewer, since they have the subject knowledge here.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This patch should use hg rename.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: move two test files -> chrome tests (2.0)

updated with hg rename vs hg delete/add

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 527180 [details] [diff] [review]
move two test files -> chrome tests (2.0)

Thanks!

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=f6677d8c32fc