a couple of layout/base mochitests should be moved to mochitest-chrome tests

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [specialpowers])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
in trying to get the layout/base/tests/test_* mochitests running with only specialPowers, I noticed that a couple test files were doing things that should really belong in mochitest-chrome:
 - test_bug370436.html
 - test_bug420499.xul

In addition there are some reftest style tests in test_reftests_with_caret.html which I am not sure should be in mochitest-plain.
(Assignee)

Updated

6 years ago
Whiteboard: [specialpowers]
(Assignee)

Comment 1

6 years ago
Created attachment 526898 [details] [diff] [review]
move two test files -> chrome tests (1.0)

simple patch to move some tests from mochitest plain to chrome.
Assignee: nobody → jmaher
Attachment #526898 - Flags: review?(ted.mielczarek)
Comment on attachment 526898 [details] [diff] [review]
move two test files -> chrome tests (1.0)

I think for moving tests to chrome you should get review from the original test author or reviewer, since they have the subject knowledge here.
Attachment #526898 - Flags: review?(ted.mielczarek) → review?(roc)
This patch should use hg rename.
(Assignee)

Comment 4

6 years ago
Created attachment 527180 [details] [diff] [review]
move two test files -> chrome tests (2.0)

updated with hg rename vs hg delete/add
Attachment #526898 - Attachment is obsolete: true
Attachment #526898 - Flags: review?(roc)
Attachment #527180 - Flags: review?(roc)
Comment on attachment 527180 [details] [diff] [review]
move two test files -> chrome tests (2.0)

Thanks!
Attachment #527180 - Flags: review?(roc) → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=f6677d8c32fc
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.