Last Comment Bug 651075 - Make content/html/content/test/test_bug386496.html non flaky
: Make content/html/content/test/test_bug386496.html non flaky
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla6
Assigned To: Mounir Lamouri (:mounir)
: Andrew Overholt [:overholt]
Depends on:
Blocks: FlakyTimeout
  Show dependency treegraph
Reported: 2011-04-19 04:23 PDT by Mounir Lamouri (:mounir)
Modified: 2011-04-29 09:30 PDT (History)
1 user (show)
mounir: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Basically a rewrite of the test (2.98 KB, patch)
2011-04-21 09:48 PDT, Mounir Lamouri (:mounir)
ehsan: review+
Details | Diff | Splinter Review

Description User image Mounir Lamouri (:mounir) 2011-04-19 04:23:18 PDT
I didn't found any obvious way to do that.
Comment 1 User image :Ehsan Akhgari 2011-04-19 12:04:40 PDT
Set an unload event handler on the iframe, switch to setTimeout(0) and make sure that the event handler is not called.
Comment 2 User image Mounir Lamouri (:mounir) 2011-04-21 09:48:51 PDT
Created attachment 527562 [details] [diff] [review]
Basically a rewrite of the test
Comment 3 User image Mounir Lamouri (:mounir) 2011-04-21 09:52:32 PDT
And FTR, this test was testing nothing: the timeout was too low to really catch a failure and when higher, the failure was because the check was forbidden (js exception was thrown). Lovely flaky one.
Comment 4 User image :Ehsan Akhgari 2011-04-25 12:54:15 PDT
Comment on attachment 527562 [details] [diff] [review]
Basically a rewrite of the test

Review of attachment 527562 [details] [diff] [review]:

Looks good!
Comment 5 User image Mounir Lamouri (:mounir) 2011-04-29 09:30:10 PDT

Note You need to log in before you can comment on or make changes to this bug.