The default bug view has changed. See this FAQ.

Make content/html/content/test/test_bug386496.html non flaky

RESOLVED FIXED in mozilla6

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla6
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
I didn't found any obvious way to do that.
Set an unload event handler on the iframe, switch to setTimeout(0) and make sure that the event handler is not called.
(Assignee)

Comment 2

6 years ago
Created attachment 527562 [details] [diff] [review]
Basically a rewrite of the test
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #527562 - Flags: review?(ehsan)
(Assignee)

Updated

6 years ago
Attachment #527562 - Attachment description: Basically a rewrite of the patch → Basically a rewrite of the test
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
(Assignee)

Comment 3

6 years ago
And FTR, this test was testing nothing: the timeout was too low to really catch a failure and when higher, the failure was because the check was forbidden (js exception was thrown). Lovely flaky one.
Comment on attachment 527562 [details] [diff] [review]
Basically a rewrite of the test

Review of attachment 527562 [details] [diff] [review]:

Looks good!
Attachment #527562 - Flags: review?(ehsan) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [needs review] → [fixed in cedar]
(Assignee)

Comment 5

6 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/ebf02b534397
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.