The default bug view has changed. See this FAQ.

Use addLoadEvent instead of <body onload=""> in content/html/content/tests/

RESOLVED FIXED in mozilla6

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla6
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 526953 [details] [diff] [review]
Patch v1
Attachment #526953 - Flags: review?(ehsan)
(Assignee)

Comment 1

6 years ago
Created attachment 526957 [details] [diff] [review]
Patch v2

With even more of those.
Though, it's really not important.
Attachment #526953 - Attachment is obsolete: true
Attachment #526953 - Flags: review?(ehsan)
Attachment #526957 - Flags: review?(ehsan)
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
Hmm, the onload property should work just as good as a callback passed to addLoadEvent.  I'm not sure what is the purpose behind these patches.
(Assignee)

Comment 3

6 years ago
(In reply to comment #2)
> Hmm, the onload property should work just as good as a callback passed to
> addLoadEvent.  I'm not sure what is the purpose behind these patches.

It's much more a clean-up than a QA improvement: I think having the onload in <body> is much more hard to parse than a addLoadEvent that should usually be at the beginning or at the end of the <script> section.
Comment on attachment 526957 [details] [diff] [review]
Patch v2

OK, fair enough.
Attachment #526957 - Flags: review?(ehsan) → review+
(Assignee)

Comment 5

6 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/1ebe64a0f85f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs review]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.