651197 - Manifest Destiny - Support relative paths in the 'path' attribute when not set in the section

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

I didn't know how to make the title not sound confusing, but basically if you have a manifest that lives in '/here/' that looks like:
[foo]
path = 'bar/baz'

the resulting path will be '/here/foo'. This is because we do a path.join on section instead of path: http://hg.mozilla.org/automation/ManifestDestiny/file/ab34ed26aea9/manifestparser.py#l227

Easy fix:
- test['path'] = os.path.join(here, section)
+ test['path'] = os.path.join(here, test['path'])

Comment 1

[Andrew Halberstadt [:ahal]]

str:

1) make the following manifest:
[foo]
path = some/relative/path

2) run the following code

from manifestparser import *
parser = ManifestParser()
parser.read('manifest.ini')
foo = parser.get()
for bar in foo:
    print bar['path']


results:
expected path - '/here/some/relative/path'
actual path - '/here/foo'

The one liner in the above comment should fix this.

Comment 2

[Jeff Hammel]

Attachment: fix

fix + testcase.  I can't push, for some reason, but if anyone wants to check this in, please do

Comment 3

[Jeff Hammel]

Pushed to pypi as http://pypi.python.org/pypi/ManifestDestiny/0.3.1

Comment 4

[Jeff Hammel]

pushed: http://hg.mozilla.org/automation/ManifestDestiny/rev/2460d06c8f12