65122 - dsa_NewKey requires parameter be NULL

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Jamie Nicolson]

This is in NSS_3_1_1_RTM, but it doesn't look like it's changed on the tip.

NSC_GenerateKeyPair calls DSA_NewKey, passing in the address of a
DSAPrivateKey*. This pointer is not initialized to NULL. DSA_NewKey passes the
pointer's address to dsa_NewKey, which verifies that the pointer is in fact
NULL. It's not NULL, so the keygen fails with SEC_ERROR_INVALID_ARGS. The
requirement that the pointer be NULL is not documented, so I think it should be
removed. This line 82 or 83 of dsa.c, depending on which version you check out.

I propose this
    if (!params || !privKey || *privKey) {
be changed to this
    if (!params || !privKey) {

Comment 1

[Jamie Nicolson]

This breaks under JSS so we do need to fix it in 3.2.

Comment 2

[Ian McGreer]

Attachment: here is the patch. I will check it in tomorrow if no complaints.

Comment 3

[Wan-Teh Chang]

Ian, you can check in the fix for this bug.

Comment 4

[Ian McGreer]

patch has been checked in.