cycle collector doesn't add marked JS objects correctly with WANT_ALL_TRACES

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
In Bug 641910 I added code to prevent marked JS objects from being added to the cycle collector graph, so I removed the corresponding check for these objects from nsXPConnect::Traverse.  Unfortunately, I forgot that when WANT_ALL_TRACES is enabled, marked JS objects are still added to the cycle collector graph.  In a non-DEBUG_CC build of Firefox, WANT_ALL_TRACES is only enabled when there is a listener, so the main consequence of this change is that it breaks the cycle collector graph dumping code added by Bug 466157.

This could be fixed by adding in some kind of check for WantAllTraces into the test, but I think it makes more sense to just back out the changes I made to nsXPConnect::Traverse, because the mark bit checking should be quick.
(Assignee)

Updated

6 years ago
Assignee: nobody → continuation
Blocks: 466157
(Assignee)

Comment 1

6 years ago
Created attachment 527826 [details] [diff] [review]
fix WANT_ALL_TRACES CC by reverting nsXPConnect changes
Attachment #527826 - Flags: review?(peterv)
Attachment #527826 - Flags: review?(peterv) → review+
(Assignee)

Updated

6 years ago
Blocks: 654041
(Assignee)

Updated

6 years ago
No longer blocks: 654041
(Assignee)

Comment 2

6 years ago
I made a try server push against the latest mozilla-central.

http://tbpl.mozilla.org/?tree=Try&rev=4934df3ec265

Everything passed, except a couple of Android and JP tests that don't seem to be visible on m-c, and for whatever reason Windows opt hasn't even finished building yet.
(Assignee)

Comment 3

6 years ago
Mochitest 1 failed on WinXP opt, but otherwise the Windows opt builds passed.  I guess I should figure out what the deal is with that.
(Assignee)

Comment 4

6 years ago
I reran the Windows opt Mochitest 1 and they both came out clean, so I think this patch is good to go.
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/mozilla-central/rev/a92024952aab
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.