65129 - keyboard events go to window while playing game on a page

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[shrirang khanzode]

seen on mac trunk, java plugin installed
I observed this bug while verifying bug 58957 on mac (bnesse had mentioned this 
same problem in 58957, so am filing this bug since I dunno if a bug was filed 
for that ).

Steps:

1 Go to the above url
2 Start the game
3 Observe that pressing the spacebar (to fire) also scrolls the window down, and 
pressing the Up Arrow key moves the window up.

Expected: Keyboard events should not affect the browser window and should work 
only on the plugin.

Comment 1

[shrirang khanzode]

cc:junruh

Comment 2

[saari (gone)]

Thanks, I've been meaning to file this. 

Comment 3

[Peter Lubczynski]

Chris, did you check-in your patch to the branch as well?

Comment 4

[shrirang khanzode]

Pls note : this is mac only.

Comment 5

[saari (gone)]

Yes, I checked into the branch and trunk. This is another issue though. The
plugin didn't get key events at all before, now it does, but this is a further
problem.

Comment 6

[shrirang khanzode]

keyboard events don't work for me on the latest mac branch build 20010111.

Comment 7

[saari (gone)]

So I wrote the code to capture events at the right level only to discover
nsPluginInstanceOwner::Init never gets called! That doesn't seem right...

Comment 8

[saari (gone)]

Nevermind that last comment, I'm an idiot.

Comment 9

[saari (gone)]

Attachment: Rough draft, but it works. Needs a bit of clean up is all.

Comment 10

[saari (gone)]

Attachment: This patch is ready to go

Comment 11

[Angela Butler]

Adding branch accept to status whiteboard.  Chris, please check into the branch 
ASAP. Thx
.Angela...

Comment 12

[saari (gone)]

fixed

Comment 13

[shrirang khanzode]

This is fixed on the branch build on mac(0117).Keyboard events do not go to 
window anymore. I need to verify this on the mac trunk build tomorrow.

Comment 14

[shrirang khanzode]

working fine on mac trunk (0117). Marking VERIFIED.