651458 - "test_contextmenu.html | menuitem context-delete has same accesskey as context-sendpage" since bug 647685 landing

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1303235616.1303236491.32685.gz
Linux comm-central-trunk debug test mochitests-5/5 on 2011/04/19 10:53:36
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey2.1/1303253310.1303254660.23657.gz
WINNT 5.2 comm-2.0 debug test mochitests-5/5 on 2011/04/19 15:48:30
{
456 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | menuitem context-delete has same accesskey as context-sendpage
468 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #2 (context-undo) name - got "context-sendpage", expected "context-undo"
... [lots of others]
}

Comment 1

[Philip Chee]

The two menu items should not appear at the same time. Does the test check if the one of the two menuitems is not visible? Serge?

Comment 2

[Serge Gautherie (:sgautherie)]

Here is what I can make of it:


*** Source code w.r.t these menuitems:

http://mxr.mozilla.org/comm-central/search?string=context%5C-delete%5B%5EA%5D&regexp=on&case=1&find=%2Fsuite%2F
{
/suite/browser/test/mochitest/test_contextmenu.html
    * lines ...
/suite/common/nsContextMenu.js
    * line 332 -- this.showItem("context-delete", this.onTextInput);
/suite/common/contentAreaContextOverlay.xul
    * line 251 -- <menuitem id="context-delete"
}
NB: For some reason, I can't get a repo.-wide search to complete, so I assume it's in SeaMonkey only.

http://mxr.mozilla.org/comm-central/search?string=context-sendpage&case=on&find=%2Fsuite%2Fbrowser%2F
{
/suite/browser/test/mochitest/test_contextmenu.html
    * lines ...
/suite/browser/mailNavigatorOverlay.xul
    * line 53 -- <menuitem id="context-sendpage"
/suite/browser/mailNavigatorOverlay.js
    * line 185 -- gContextMenu.showItem("context-sendpage", shouldShowSendPage);
}


*** Some more log details:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1303235616.1303236491.32685.gz&fulltext=1#err0
{
428 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | Starting test #5
...
434 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | child menuitem #50 has an ID
435 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | menuitem context-sendpage has a label
436 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | menuitem context-sendpage has an access key
...
453 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | child menuitem #59 has an ID
454 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | menuitem context-delete has a label
455 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | menuitem context-delete has an access key
456 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | menuitem context-delete has same accesskey as context-sendpage
...
}


*** Test source code:

http://mxr.mozilla.org/comm-central/source/suite/browser/test/mochitest/test_contextmenu.html?force=1
{
53 function getVisibleMenuItems(aMenu) {
58         if (item.hidden)
59             continue;
81                   ok(false, "menuitem " + item.id + " has same accesskey as " + accessKeys[key]);

166 function runTest(testNum) {
236     case 5:
237         // Context menu for text input field
}

"context-sendpage" is not listed (= missing ?) for test "5": hopefully a hint at a fix...

Yet, it would be good to explain (first) what bug 647685 changed to cause this bug.

Comment 3

[Philip Chee]

Probably needs attachment 527218 [details] [diff] [review] (Fix startup error) since this buggers up initMailContextMenuItems()

Comment 4

[Philip Chee]

> Probably needs attachment 527218 [details] [diff] [review] (Fix startup error) since this buggers up
> initMailContextMenuItems()
Checked in. Do you still see this problem?

Comment 5

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey2.1/1303412294.1303413317.9330.gz
Linux comm-2.0 debug test mochitests-5/5 on 2011/04/21 11:58:14

V.Fixed