Build failure in nsAudioStream.cpp on OpenBSD

RESOLVED FIXED in mozilla6

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

Trunk
mozilla6
All
OpenBSD
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Very similar to nsWebMReader.cpp patch in https://bug633857.bugzilla.mozilla.org/attachment.cgi?id=525961

As of now, build fails with :
/home/landry/src/mozilla-central/content/media/nsAudioStream.cpp: In member function 'virtual PRInt64 nsAudioStreamLocal::GetSampleOffset()
':
/home/landry/src/mozilla-central/content/media/nsAudioStream.cpp:571: error: invalid conversion from 'PRInt64*' to 'int64_t*'
/home/landry/src/mozilla-central/content/media/nsAudioStream.cpp:571: error:   initializing argument 3 of 'int sa_stream_get_position(sa_st
ream_t*, sa_position_t, int64_t*)'
(Assignee)

Comment 1

6 years ago
Created attachment 527232 [details] [diff] [review]
Use int64_t instead of PRInt64

Attached patch fixes the issue
Attachment #527232 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Blocks: 650665
Attachment #527232 - Flags: review?(roc) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Assignee: nobody → landry
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Version: unspecified → Trunk
http://hg.mozilla.org/mozilla-central/rev/b0c37efbd9a7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
(Assignee)

Updated

5 years ago
Depends on: 634793
You need to log in before you can comment on or make changes to this bug.