651525 - permaorange: browser_bookmarks_tags.js | All tags are associated with specified bookmark - Got 0, expected 4, then NS_ERROR_ILLEGAL_VALUE from nsINavBookmarksService.runInBatchMode and a timeout

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Phil Ringnalda (:philor)]

TEST-INFO | chrome://mochitests/content/browser/mobile/chrome/browser_bookmarks_tags.js | Console message: [JavaScript Error: "scrollbox.firstChild is null" {file: "chrome://browser/content/bindings/dialog.xml" line: 49}]
TEST-PASS | chrome://mochitests/content/browser/mobile/chrome/browser_bookmarks_tags.js | chrome://mochitests/content/browser/mobile/chrome/browser_blank_02.html should be added.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/mobile/chrome/browser_bookmarks_tags.js | All tags are associated with specified bookmark - Got 0, expected 4

TEST-INFO | chrome://mochitests/content/browser/mobile/chrome/browser_bookmarks_tags.js | Test editing tags to bookmark
TEST-INFO | chrome://mochitests/content/browser/mobile/chrome/browser_bookmarks_tags.js | Console message: [JavaScript Error: "uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.runInBatchMode]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/components/nsTaggingService.js :: TS_tagURI :: line 216"  data: no]"]
NEXT ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/mobile/chrome/browser_bookmarks_tags.js | Test timed out

Don't know whether the "scrollbox.firstChild is null" which starts in an earlier test, bug 651522, is related or not. Without having looked yet, I'd bet that the error and timeout are the result of having failed to tag, but then proceeding as though those tags can be edited.

Comment 1

[Wesley Johnston (:wesj)]

Adding sdwilsh, as he said he might have some idea about this.

Comment 2

[Shawn Wilsher :sdwilsh]

Hey Marco; does this error look like something obvious to you by chance?

Comment 3

[Marco Bonardo [:mak]]

No it's not something obvious.  The bookmark is added, then tags are not. I suppose that xul problem is related, since the tags are added by setting the value of a textbox and clicking a done button. This must be failing.
At this point we move to the next test but the bookmarking panel is still somehow alive, and it tries now to store the previously not-written tags to a null uri (on blur or unload?), or writing null tags to a valid uri.
Otherwise we'd see some output from the second test.

Comment 4

[Marco Bonardo [:mak]]

the runinbatchmode is the internal batch in tagURI (http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsTaggingService.js#189) the illegal value tells me some of the api inside that batch is working on a null uri or null tags.

Comment 5

[Phil Ringnalda (:philor)]

Is tagging.getURIsForTag("thistaghasneverbeenused") supposed to happily return null? That runInBatchMode exception and timeout looks nicely placed to be http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/tests/browser_bookmarks_tags.js#130 taking down the test instead of returning the zero URIs with that tag (since the earlier test failed to add it).

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I am in the process of putting together a patch to use a bookmark observer to wait for the tags to actually be saved before testing for them. I theory is that the code:

donebutton.click();

starts updating the tags here:

http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/bindings.xml#743

If any of that happens async, we could be attempting to test before the data is saved.

Comment 7

[Cristian Nicolae (:xti)]

This issue is still reproducing on: 
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:6.0a1)Gecko/20110517
Firefox/6.0a1 Fennec/6.0a1
Device: HTC Desire
OS: Android 2.2

Comment 8

[Cristian Nicolae (:xti)]

Attachment: Screenshot 1

Comment 9

[Cristian Nicolae (:xti)]

Attachment: Screenshot 2

Comment 10

[Phil Ringnalda (:philor)]

Disabled on Android in http://hg.mozilla.org/mozilla-central/rev/d0583d604249