651534 - permaorange: browser_click_content.js | Test timed out

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Phil Ringnalda (:philor)]

TEST-PASS | chrome://mochitests/content/browser/mobile/chrome/browser_click_content.js | URL Matches newly created Tab
TEST-INFO | chrome://mochitests/content/browser/mobile/chrome/browser_click_content.js | Console message: [JavaScript Error: "uncaught exception: waitFor timeout"]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/mobile/chrome/browser_click_content.js | Test timed out

Comment 1

[Phil Ringnalda (:philor)]

Not actually Android-specific, n900s do the same thing.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Potential Fix

I haven't ever seen this happen on desktop, but it seems likely to me its just a timing issue.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 527684 [details] [diff] [review]
Potential Fix

>-  element.addEventListener("click", clickFired, true);
>+  element.addEventListener("click", function(aEvent) {

You should remove the event handler here using the arguments.callee trick

>+    clickFired(aEvent);
>+    checkClick();
>+  }, true);
> 
>   EventUtils.synthesizeMouseForContent(element, 1, 1, {}, window);
>-  waitFor(checkClick, function() { return isClickFired });
> }
> 
> function checkClick() {
>   ok(isClickFired, "Click handler fired");
>   element.removeEventListener("click", clickFired, true);

This one ^

>-  element.addEventListener("click", clickFired, true);
>+  element.addEventListener("click", function(aEvent) {

Same thing

>+    clickFired(aEvent);
>+    checkPosition();
>+  }, true);
> 
>   let rect = getBoundingContentRect(element);
>   EventUtils.synthesizeMouse(element, 1, rect.height + 10, {}, window);
>-  waitFor(checkPosition, function() { return isClickFired });
> }
> 
> function checkPosition() {
>   element.removeEventListener("click", clickFired, true);

This one ^


Can we also remove isClickFired ?

r- but close, and make sure this doesn't break on desktop

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Updated patch

Updated to notes. Also removed the isClickFired checks.

Comment 5

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/mozilla-central/rev/83b7d7837e6b

Comment 6

[Phil Ringnalda (:philor)]

Still failing every time.

Comment 7

[Phil Ringnalda (:philor)]

Not sure whether this is significant, but the n900 failures come with a screenshot in the log, which shows that iframe-1, the one where we're firing a click at 1,1, is almost completely out of view, so we're firing a click at something offscreen.

Comment 8

[Phil Ringnalda (:philor)]

Disabled on Android in http://hg.mozilla.org/mozilla-central/rev/d0583d604249