nsMathMLmunderFrame.cpp:285:11: warning: unused variable 'xHeight'

RESOLVED FIXED

Status

()

Core
MathML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 527328 [details] [diff] [review]
fix

Filing bug on this warning:
> layout/mathml/nsMathMLmunderFrame.cpp:285:11: warning: unused variable 'xHeight

Looks like this variable has actually been unused since it was first added, back in the year 2000:
http://mxr.mozilla.org/firefox/source/layout/mathml/base/src/nsMathMLmunderFrame.cpp
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/mathml/base/src&command=DIFF_FRAMESET&file=nsMathMLmunderFrame.cpp&rev2=1.10&rev1=1.9

GCC only recently started warning us about this, though, because this variable had been set by passing it as an outparam -- which looked like we were 'using' it -- up until zwol tweaked it to set it directly, in Bug 174055 part 6.

Attached patch kills the variable.
Attachment #527328 - Flags: review?(dbaron)
(Assignee)

Updated

6 years ago
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #527328 - Flags: review?(dbaron) → review+
(Assignee)

Comment 1

6 years ago
pushed: http://hg.mozilla.org/mozilla-central/rev/48b26f2254f8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.