Aurora About Dialog channel switcher should have left-aligned, not centered text

VERIFIED FIXED in Firefox 5

Status

()

defect
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: jboriss, Assigned: Margaret)

Tracking

5 Branch
Firefox 5
Points:
---

Firefox Tracking Flags

(firefox5 fixed)

Details

(Whiteboard: [channel-switcher] [bugday-20110513] )

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

8 years ago
Currently, when users click the "change" link in the Firefox button's channel switcher, the text in the About Aurora Dialog box goes from left-aligned to center-aligned.

Firstly, we should never be actively changing alignment on a screen the user's currently interacting with.

Secondly, we should not be centering text in multiple-sentence paragraphs, ever.  Doing so requires the user's scanning gaze to begin at different starting points on each line.  It also produces an ugly jagged line effect on both sides of our text.

The channel switcher should remain left aligned, except for the Apply and Cancel buttons at the bottom, which should be right-aligned in Vista for consistency across the OS.
-> rob (I think)
Component: General → Application Update
Product: Firefox → Toolkit
QA Contact: general → application.update
Version: 4.0 Branch → 5 Branch
maybe this: 

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/aboutDialog.xul

129           <vbox id="channelSelector">
130             <hbox pack="center" align="center">
131               <label>&channel.selector.start;</label>
This is Firefox specific ui so over to Firefox -> General since that is the component where bug 644517 implemented this ui.
Component: Application Update → General
Product: Toolkit → Firefox
QA Contact: application.update → general
(Assignee)

Comment 4

8 years ago
Posted patch patch (obsolete) — Splinter Review
This also works in RTL.
Assignee: nobody → margaret.leibovic
Status: NEW → ASSIGNED
Attachment #527369 - Flags: review?(gavin.sharp)
(Assignee)

Comment 5

8 years ago
(Assignee)

Comment 6

8 years ago
Posted patch patch (flips buttons on osx) (obsolete) — Splinter Review
This patch flips the button order on OSX, as per Boriss's request in #ux.
Attachment #527369 - Attachment is obsolete: true
Attachment #527369 - Flags: review?(gavin.sharp)
Attachment #527374 - Flags: review?(gavin.sharp)
Comment on attachment 527374 [details] [diff] [review]
patch (flips buttons on osx)

I think you want XP_UNIX (which covers both Linux and Mac) rather than XP_MACOSX, which matches what we do for normal dialogs:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/dialog.xml#17
Attachment #527374 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 8

8 years ago
Attachment #527374 - Attachment is obsolete: true
(Reporter)

Updated

8 years ago
Status: ASSIGNED → NEW
(Assignee)

Comment 9

8 years ago
http://hg.mozilla.org/mozilla-central/rev/1bf036202718
Status: NEW → RESOLVED
Last Resolved: 8 years ago
OS: Windows Vista → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [good first bug]
Target Milestone: --- → Firefox 6
(Assignee)

Comment 10

8 years ago
Comment on attachment 527391 [details] [diff] [review]
patch for check-in

Asking for approval to land on aurora. This is a low risk appearance change that polishes the look of the channel switcher.
Attachment #527391 - Flags: approval-mozilla-aurora?
(In reply to comment #10)
> Comment on attachment 527391 [details] [diff] [review]
> patch for check-in
> 
> Asking for approval to land on aurora. This is a low risk appearance change
> that polishes the look of the channel switcher.

I'd like to see this backported too, especially since this is the first time people will see the channel switcher.
Attachment #527391 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 12

8 years ago
Landed on mozilla-aurora:

http://hg.mozilla.org/mozilla-aurora/rev/57bd0687fd1f
(Assignee)

Comment 13

8 years ago
Updating target milestone to Firefox 5, since this will be in there now that it's in aurora.
Target Milestone: Firefox 6 → Firefox 5
(Assignee)

Comment 14

8 years ago
Also marking as fixed for Firefox 5.
Whiteboard: [channel-switcher]
verifying in  Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0a2) Gecko/20110510 Firefox/5.0a2
Status: RESOLVED → VERIFIED
Whiteboard: [channel-switcher] → [channel-switcher] [bugday-20110513]
You need to log in before you can comment on or make changes to this bug.