651578 - Aurora About Dialog channel switcher should have left-aligned, not centered text

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Screenshots: Left vs center-aligned aurora about dialog (screenshots courtesy of Asa)

Currently, when users click the "change" link in the Firefox button's channel switcher, the text in the About Aurora Dialog box goes from left-aligned to center-aligned.

Firstly, we should never be actively changing alignment on a screen the user's currently interacting with.

Secondly, we should not be centering text in multiple-sentence paragraphs, ever.  Doing so requires the user's scanning gaze to begin at different starting points on each line.  It also produces an ugly jagged line effect on both sides of our text.

The channel switcher should remain left aligned, except for the Apply and Cancel buttons at the bottom, which should be right-aligned in Vista for consistency across the OS.

Comment 1

[Asa Dotzler [:asa]]

-> rob (I think)

Comment 2

[Asa Dotzler [:asa]]

maybe this: 

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/aboutDialog.xul

129           <vbox id="channelSelector">
130             <hbox pack="center" align="center">
131               <label>&channel.selector.start;</label>

Comment 3

[Robert Strong (they/them - no direct email)]

This is Firefox specific ui so over to Firefox -> General since that is the component where bug 644517 implemented this ui.

Comment 4

[:Margaret Leibovic]

Attachment: patch

This also works in RTL.

Comment 5

[:Margaret Leibovic]

Attachment: screenshot with patch

Comment 6

[:Margaret Leibovic]

Attachment: patch (flips buttons on osx)

This patch flips the button order on OSX, as per Boriss's request in #ux.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 527374 [details] [diff] [review]
patch (flips buttons on osx)

I think you want XP_UNIX (which covers both Linux and Mac) rather than XP_MACOSX, which matches what we do for normal dialogs:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/dialog.xml#17

Comment 8

[:Margaret Leibovic]

Attachment: patch for check-in

Comment 9

[:Margaret Leibovic]

http://hg.mozilla.org/mozilla-central/rev/1bf036202718

Comment 10

[:Margaret Leibovic]

Comment on attachment 527391 [details] [diff] [review]
patch for check-in

Asking for approval to land on aurora. This is a low risk appearance change that polishes the look of the channel switcher.

Comment 11

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #10)
> Comment on attachment 527391 [details] [diff] [review]
> patch for check-in
> 
> Asking for approval to land on aurora. This is a low risk appearance change
> that polishes the look of the channel switcher.

I'd like to see this backported too, especially since this is the first time people will see the channel switcher.

Comment 12

[:Margaret Leibovic]

Landed on mozilla-aurora:

http://hg.mozilla.org/mozilla-aurora/rev/57bd0687fd1f

Comment 13

[:Margaret Leibovic]

Updating target milestone to Firefox 5, since this will be in there now that it's in aurora.

Comment 14

[:Margaret Leibovic]

Also marking as fixed for Firefox 5.

Comment 15

[Stephanie Daugherty [:sdaugherty]]

verifying in  Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0a2) Gecko/20110510 Firefox/5.0a2