Closed Bug 651596 Opened 14 years ago Closed 14 years ago

Eliminate IWeaveCrypto

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

(Keywords: dev-doc-needed, Whiteboard: [prune][qa-])

Attachments

(1 file)

services/crypto/modules/WeaveCrypto.js 48:const ALGORITHM = Ci.IWeaveCrypto.AES_256_CBC; 58: QueryInterface: XPCOMUtils.generateQI([Ci.IWeaveCrypto]), 383: // IWeaveCrypto interfaces services/crypto/tests/unit/test_crypto_crypt.js 8: .getService(Ci.IWeaveCrypto); services/crypto/tests/unit/test_crypto_random.js 8: .getService(Ci.IWeaveCrypto); 54: cryptoSvc.algorithm = Ci.IWeaveCrypto.AES_256_CBC; services/sync/tests/unit/head_helpers.js 182: * Mock implementation of IWeaveCrypto. It does not encrypt or services/sync/tests/unit/test_utils_deriveKey.js 8: .getService(Ci.IWeaveCrypto);
Whiteboard: [prune]
This builds, passes tests, and doesn't generate IWeaveCrypto.idl in output. On r+ I'll throw it at try.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #527375 - Flags: review?(philipp)
Attachment #527375 - Attachment is patch: true
Attachment #527375 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 527375 [details] [diff] [review] Proposed patch. v1 >diff --git a/services/sync/tests/unit/test_utils_deriveKey.js b/services/sync/tests/unit/test_utils_deriveKey.js >--- a/services/sync/tests/unit/test_utils_deriveKey.js >+++ b/services/sync/tests/unit/test_utils_deriveKey.js >@@ -1,19 +1,12 @@ >-let cryptoSvc; >-try { >- Components.utils.import("resource://services-crypto/WeaveCrypto.js"); >- cryptoSvc = new WeaveCrypto(); >-} catch (ex) { >- // Fallback to binary WeaveCrypto >- cryptoSvc = Cc["@labs.mozilla.com/Weave/Crypto;1"] >- .getService(Ci.IWeaveCrypto); >-} >+Cu.import("resource://services-crypto/WeaveCrypto.js"); >+Cu.import("resource://services-sync/util.js"); > >-Cu.import("resource://services-sync/util.js"); >+cryptoSvc = new WeaveCrypto(); Where did the 'let' go? r=me with that added back. N.B.: While this removes an interface that we once shipped, it's not one that was ever actually used or documented, so I don't think we need superreview or anything like that. WeaveCrypto isn't public API, anyway.
Attachment #527375 - Flags: review?(philipp) → review+
Whiteboard: [prune] → [prune][fixed in services][qa-]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [prune][fixed in services][qa-] → [prune][qa-]
Target Milestone: --- → mozilla6
This is being used by at least one extension. Flagging for developer documentation.
Keywords: dev-doc-needed
(In reply to comment #5) > This is being used by at least one extension. Flagging for developer > documentation. It was never documented in the first place, so why does the removal need to be documented.
Keywords: dev-doc-needed
Because it is a fact that this interface has been used in add-ons, and there's an MDC article dedicated to breaking compatibility changes, and that has nothing to do with the interface being documented before or not.
Component: Firefox Sync: Crypto → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: