The default bug view has changed. See this FAQ.

TestXPC unit test failure

RESOLVED FIXED

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Mook (work), Assigned: Mook (work))

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 527413 [details] [diff] [review]
add flags

There's a TestXPC in dist/bin, from http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/tests/TestXPC.cpp

Actually trying to run the test aborts:

Assertion failure: clasp->flags & JSCLASS_IS_GLOBAL, at .../src/js/src/jsapi.cpp:3062
Aborted

It makes me feel less guilty to actually attach the fix too - it's not like I took part in thinking about it ;)
Attachment #527413 - Flags: review?(jorendorff)
Comment on attachment 527413 [details] [diff] [review]
add flags

Review of attachment 527413 [details] [diff] [review]:

r=me, but it also seems like a bug that we didn't find out about this until now. Is this test useful? It must not run on our build/test machines, at least not in debug builds. Either that, or the assertion was happening but wasn't being detected and reported properly. Please file the follow-up bug to get that fixed!
Attachment #527413 - Flags: review?(jorendorff) → review+

Updated

6 years ago
Blocks: 653960

Comment 2

6 years ago
http://hg.mozilla.org/mozilla-central/rev/deb13b9167ad

Follow up filed as bug 653960
Assignee: nobody → marky
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.