Closed
Bug 651663
Opened 14 years ago
Closed 14 years ago
TestXPC unit test failure
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
People
(Reporter: mark.yen, Assigned: mark.yen)
References
()
Details
Attachments
(1 file)
|
672 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
There's a TestXPC in dist/bin, from http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/tests/TestXPC.cpp
Actually trying to run the test aborts:
Assertion failure: clasp->flags & JSCLASS_IS_GLOBAL, at .../src/js/src/jsapi.cpp:3062
Aborted
It makes me feel less guilty to actually attach the fix too - it's not like I took part in thinking about it ;)
Attachment #527413 -
Flags: review?(jorendorff)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 527413 [details] [diff] [review]
add flags
Review of attachment 527413 [details] [diff] [review]:
r=me, but it also seems like a bug that we didn't find out about this until now. Is this test useful? It must not run on our build/test machines, at least not in debug builds. Either that, or the assertion was happening but wasn't being detected and reported properly. Please file the follow-up bug to get that fixed!
Attachment #527413 -
Flags: review?(jorendorff) → review+
http://hg.mozilla.org/mozilla-central/rev/deb13b9167ad
Follow up filed as bug 653960
Assignee: nobody → marky
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•