Closed Bug 651679 Opened 14 years ago Closed 14 years ago

Remove dead code gBrowser.mTabContainer.mAllTabsPopup._updateTabsVisibilityStatus

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: tabutils+bugzilla, Unassigned)

References

Details

User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110420 Firefox/6.0a1 Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110420 Firefox/6.0a1 http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#3724 3724 <method name="_updateTabsVisibilityStatus"> 3725 <body><![CDATA[ 3726 var tabContainer = gBrowser.tabContainer; 3727 // We don't want menu item decoration unless there is overflow. 3728 if (tabContainer.getAttribute("overflow") != "true") 3729 return; 3730 3731 var tabstripBO = tabContainer.mTabstrip.scrollBoxObject; 3732 for (var i = 0; i < this.childNodes.length; i++) { 3733 var curTabBO = this.childNodes[i].tab.boxObject; 3734 if (curTabBO.screenX >= tabstripBO.screenX && 3735 curTabBO.screenX + curTabBO.width <= tabstripBO.screenX + tabstripBO.width) 3736 this.childNodes[i].setAttribute("tabIsVisible", "true"); 3737 else 3738 this.childNodes[i].removeAttribute("tabIsVisible"); 3739 } 3740 ]]></body> 3741 </method> This method is just setting "tabIsVisible" attribute, which seems never used. Reproducible: Always
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [good first bug]
Depends on: 626903
Once the patch for bug 626903 lands (it's checkin-needed at the time of this writing), we'll be using this code again. Marking this invalid now, since I might forget later.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
Whiteboard: [good first bug]
You need to log in before you can comment on or make changes to this bug.