651848 - Disable deleting news articles by default (pref-off)

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Mark Banner (:standard8)]

After separating out cancel and delete message in bug 250141, we realised in bug 644075 that this leaves users open to a new dataloss issue - if a message is deleted from a newsgroup it can't be undone.

After discussion with Joshua, we've agreed to disable the deleting of newsgroup feeds by default. We can then have a preference to turn it back on for those users that are happy to test it out further. Once bug 644075 is fixed, then we can remove the preference and have it enabled by default.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

This overrides the GetCanDeleteMessages function for news, and checks a new pref.

I've also fixed the standalone window delete button because it wasn't being disabled with just the c++ change - I changed the js code for the cmd_delete enabling to be the same as the 3 pane window.

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/6f0e51f510aa

Comment 3

[Joe Sabash [:JoeS1]]

It would be a shame to loose exposure to this most welcome feature in TB3 due to lack of discovery (pref("news.allow_delete_with_no_undo",      false);)
Can we get a relnote on this.

Comment 4

[Mark Banner (:standard8)]

I don't think this is appropriate for a relnote: It isn't a regression, and whilst it is a new feature which is disabled by default, it is also an incomplete feature - therefore I don't think we should be advertising it in relnotes.

Joshua also mentioned to me that he was really happy about separating the cancelling of a news group message and delete.