651915 - Fix MarkStack size

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gregor Wagner [:gwagner]]

There is somewhere another division missing since "limit" is the entry count:

static const size_t OBJECT_MARK_STACK_SIZE = 32768 * sizeof(JSObject *);
static const size_t XML_MARK_STACK_SIZE = 1024 * sizeof(JSXML *);
static const size_t LARGE_MARK_STACK_SIZE = 64 * sizeof(LargeMarkItem);

  objStack = {
    stack = 0x11a2a61d8, 
    tos = 0, 
    limit = 262143
  }, 
  xmlStack = {
    stack = 0x11a4a61d8, 
    tos = 0, 
    limit = 8191
  }, 
  largeStack = {
    stack = 0x11a4b61d8, 
    tos = 0, 
    limit = 511
  }

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Oops. The problem is here:
    /* Pre-allocated space for the GC mark stacks. Pointer type ensures alignment. */
    void                *gcMarkStackObjs[js::OBJECT_MARK_STACK_SIZE];
    void                *gcMarkStackXMLs[js::XML_MARK_STACK_SIZE];
    void                *gcMarkStackLarges[js::LARGE_MARK_STACK_SIZE];
So the sizes are all four times bigger than I intended. I should have divided by sizeof(void*) or something.

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Yeah that looks better.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 527589 [details] [diff] [review]
patch

Thanks.

Comment 4

[Gregor Wagner [:gwagner]]

http://hg.mozilla.org/tracemonkey/rev/d148872ae9b2

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/d148872ae9b2