651926 - gfxPlatform::Init needs to crash rather than returning an error if it fails

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Zack Weinberg (:zwol)]

+++ This bug was initially created as a clone of Bug #651498 +++
> As a side note, gfxPlatform::Init ought to crash rather than returning an error
> code -- even in production builds -- if anything fails to start up, because
> nothing checks for a null pointer return from gfxPlatform::GetPlatform, so
> we're going to crash anyway.  But this was already broken, so I think it should
> get its own bug.

Comment 1

[Zack Weinberg (:zwol)]

Attachment: patch

Thus.

Some of these may already be covered by infallible malloc but I don't feel like auditing them just now.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 527595 [details] [diff] [review]
patch

Yes please.

Comment 3

[Zack Weinberg (:zwol)]

This is done and bug 651498 isn't, so I'm switching the dependency around so this can land (it's only a textual dependency).

Comment 4

[Zack Weinberg (:zwol)]

Attachment: as will be checked in

only change is to remove said textual dependency.

Comment 5

[Zack Weinberg (:zwol)]

http://hg.mozilla.org/mozilla-central/rev/2250bc3d0532

Comment 6

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20100101 Firefox/6.0

Could you please provide a test case for this issue in order for it to be set to verified Fixed?

Comment 7

[Zack Weinberg (:zwol)]

This changed how promptly we crash under conditions that should never actually occur.  I do not believe a test case is feasible.