651973 - RegExp not released on error path in createObjectNoStatics

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Michael Wu [:mwu]]

Attachment: Release RegExp on error

Comment 1

[Chris Leary [:cdleary] (not checking bugmail)]

Comment on attachment 527648 [details] [diff] [review]
Release RegExp on error

Nice catch! Only nit is that I think SpiderMonkey style prefers combining with the above test a la:

    if (!obj ||
        !obj->initRegExp(cx, re.get())) {
        // common cleanup code
    }

Comment 2

[Jeff Walden [:Waldo]]

...except combine the two conditions to one line, like:

if (!obj || !obj->initRegExp(cx, re.get()))

because it all fits on one line, in 99ish characters.

Comment 3

[Michael Wu [:mwu]]

http://hg.mozilla.org/tracemonkey/rev/152ef9c8b2bb

Hm I forgot to make it one line.. sorry about that!

It looks sorta nice on two lines IMO anyway..

Comment 4

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/152ef9c8b2bb