651980 - Intermittent dom/src/threads/test/test_chromeWorkerJSM.xul | Test timed out

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

+++ This bug was initially created as a clone of Bug #625222 +++

I think we have a real fix, simple and short, to avoid disabling that test.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Oops, wrong patch.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/2d093cb6af1c

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 527656 [details] [diff] [review]
Patch, v1

This fixes a bug that could prevent extension authors from using Workers in their JSMs. Small, isolated fix, obviously tested ;)

Comment 4

[Johnny Stenback (:jst)]

Tracking, and I think we should take this on aurora, but we'd like to see a few more days of trunk time here...

Comment 5

[JP Rosevear [:jpr]]

How is this looking on central?  Do you have an ETA on when you will reach a comfort level with this patch?

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I just reconfirmed with Ben. The fix here worked fine on trunk and we do really want to take it on aurora as it fixes GC hazards.

Comment 7

[Johnathan Nightingale [:johnath]]

Comment on attachment 527656 [details] [diff] [review]
Patch, v1

Land it before beta merge, please!

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/b09a81573ff0