Closed Bug 651980 Opened 9 years ago Closed 9 years ago

Intermittent dom/src/threads/test/test_chromeWorkerJSM.xul | Test timed out

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox5 + fixed
status2.0 --- ?

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

(Whiteboard: fixed-on-aurora)

Attachments

(1 file, 1 obsolete file)

Attached patch Patch, v1 (obsolete) — Splinter Review
+++ This bug was initially created as a clone of Bug #625222 +++

I think we have a real fix, simple and short, to avoid disabling that test.
Attachment #527654 - Flags: review?(mrbkap)
Attached patch Patch, v1Splinter Review
Oops, wrong patch.
Attachment #527654 - Attachment is obsolete: true
Attachment #527654 - Flags: review?(mrbkap)
Attachment #527656 - Flags: review?(mrbkap)
Attachment #527656 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/mozilla-central/rev/2d093cb6af1c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 527656 [details] [diff] [review]
Patch, v1

This fixes a bug that could prevent extension authors from using Workers in their JSMs. Small, isolated fix, obviously tested ;)
Attachment #527656 - Flags: approval-mozilla-aurora?
Tracking, and I think we should take this on aurora, but we'd like to see a few more days of trunk time here...
How is this looking on central?  Do you have an ETA on when you will reach a comfort level with this patch?
I just reconfirmed with Ben. The fix here worked fine on trunk and we do really want to take it on aurora as it fixes GC hazards.
Comment on attachment 527656 [details] [diff] [review]
Patch, v1

Land it before beta merge, please!
Attachment #527656 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.