Last Comment Bug 652056 - two minor improvements to cycle collector dumps
: two minor improvements to cycle collector dumps
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-21 23:47 PDT by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2011-11-13 11:28 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch 1: get better JSTracer data (1.78 KB, patch)
2011-04-21 23:48 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
no flags Details | Diff | Review
patch 2: allow much longer urls (838 bytes, patch)
2011-04-21 23:49 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
peterv: review+
continuation: checkin+
Details | Diff | Review
patch 3: make XPCOM_CC_DRAW_GRAPHS work at shutdown too (1.02 KB, patch)
2011-04-21 23:52 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
peterv: review+
continuation: checkin+
Details | Diff | Review
peterv's CC shutdown logging patch (1.22 KB, patch)
2011-04-22 12:54 PDT, Andrew McCreight [:mccr8]
no flags Details | Diff | Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-04-21 23:47:40 PDT
During the debugging session described in http://groups.google.com/group/mozilla.dev.platform/msg/d84ea7e1219d71a0 I wrote two patches to fix things that we ran into during that session.  (I still need to test them...)
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-04-21 23:48:46 PDT
Created attachment 527730 [details] [diff] [review]
patch 1: get better JSTracer data

Now that JSTracer is binary-compatible between opt and debug, we should no longer need these ifdefs, and we can get better data in opt builds when WantDebugInfo is set.
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-04-21 23:49:11 PDT
Created attachment 527731 [details] [diff] [review]
patch 2: allow much longer urls

We needed the full URLs but couldn't get to them.
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-04-21 23:52:31 PDT
Created attachment 527732 [details] [diff] [review]
patch 3: make XPCOM_CC_DRAW_GRAPHS work at shutdown too

Here's a third one that's older and that I have tested.  I don't feel like filing a separate bug for it.  This makes XPCOM_CC_DRAW_GRAPHS apply to the shutdown collections too.
Comment 4 Andrew McCreight [:mccr8] 2011-04-22 12:54:37 PDT
Created attachment 527839 [details] [diff] [review]
peterv's CC shutdown logging patch

Peterv sent me this patch for CC shutdown logging.  Basically the same, but  factored a bit differently.  Just some food for thought.
Comment 5 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-05-02 18:48:33 PDT
Comment on attachment 527731 [details] [diff] [review]
patch 2: allow much longer urls

Well, I finally got around to testing these other 2 in opt builds.  This patch definitely works; I can't find any evidence of the other one doing so, though.
Comment 6 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-05-02 18:49:10 PDT
Landed patch 3:
http://hg.mozilla.org/mozilla-central/rev/86248f7209b7
Comment 7 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-05-09 12:18:27 PDT
Landed patch 2:
https://hg.mozilla.org/mozilla-central/rev/e2d2de2d2894
Comment 8 Andrew McCreight [:mccr8] 2011-11-11 10:12:54 PST
dbaron, you could probably close this.  2 of 3 patches landed, and the JSTracer stuff in part 1 is going to require additional futzing with the JS engine, so I'll deal with that in its own bug, bug 701415.
Comment 9 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-11-13 11:28:21 PST
Sounds good.  (And yes, I didn't land patch 1 because it didn't actually do anything useful.

Note You need to log in before you can comment on or make changes to this bug.