652056 - two minor improvements to cycle collector dumps

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

During the debugging session described in http://groups.google.com/group/mozilla.dev.platform/msg/d84ea7e1219d71a0 I wrote two patches to fix things that we ran into during that session.  (I still need to test them...)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 1: get better JSTracer data

Now that JSTracer is binary-compatible between opt and debug, we should no longer need these ifdefs, and we can get better data in opt builds when WantDebugInfo is set.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 2: allow much longer urls

We needed the full URLs but couldn't get to them.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 3: make XPCOM_CC_DRAW_GRAPHS work at shutdown too

Here's a third one that's older and that I have tested.  I don't feel like filing a separate bug for it.  This makes XPCOM_CC_DRAW_GRAPHS apply to the shutdown collections too.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: peterv's CC shutdown logging patch

Peterv sent me this patch for CC shutdown logging.  Basically the same, but  factored a bit differently.  Just some food for thought.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 527731 [details] [diff] [review]
patch 2: allow much longer urls

Well, I finally got around to testing these other 2 in opt builds.  This patch definitely works; I can't find any evidence of the other one doing so, though.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Landed patch 3:
http://hg.mozilla.org/mozilla-central/rev/86248f7209b7

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Landed patch 2:
https://hg.mozilla.org/mozilla-central/rev/e2d2de2d2894

Comment 8

[Andrew McCreight [:mccr8]]

dbaron, you could probably close this.  2 of 3 patches landed, and the JSTracer stuff in part 1 is going to require additional futzing with the JS engine, so I'll deal with that in its own bug, bug 701415.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Sounds good.  (And yes, I didn't land patch 1 because it didn't actually do anything useful.