The default bug view has changed. See this FAQ.

two minor improvements to cycle collector dumps

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
During the debugging session described in http://groups.google.com/group/mozilla.dev.platform/msg/d84ea7e1219d71a0 I wrote two patches to fix things that we ran into during that session.  (I still need to test them...)
(Assignee)

Comment 1

6 years ago
Created attachment 527730 [details] [diff] [review]
patch 1: get better JSTracer data

Now that JSTracer is binary-compatible between opt and debug, we should no longer need these ifdefs, and we can get better data in opt builds when WantDebugInfo is set.
(Assignee)

Comment 2

6 years ago
Created attachment 527731 [details] [diff] [review]
patch 2: allow much longer urls

We needed the full URLs but couldn't get to them.
(Assignee)

Comment 3

6 years ago
Created attachment 527732 [details] [diff] [review]
patch 3: make XPCOM_CC_DRAW_GRAPHS work at shutdown too

Here's a third one that's older and that I have tested.  I don't feel like filing a separate bug for it.  This makes XPCOM_CC_DRAW_GRAPHS apply to the shutdown collections too.
Attachment #527732 - Flags: review?(peterv)
Created attachment 527839 [details] [diff] [review]
peterv's CC shutdown logging patch

Peterv sent me this patch for CC shutdown logging.  Basically the same, but  factored a bit differently.  Just some food for thought.
Attachment #527732 - Flags: review?(peterv) → review+
(Assignee)

Comment 5

6 years ago
Comment on attachment 527731 [details] [diff] [review]
patch 2: allow much longer urls

Well, I finally got around to testing these other 2 in opt builds.  This patch definitely works; I can't find any evidence of the other one doing so, though.
Attachment #527731 - Flags: review?(peterv)
(Assignee)

Comment 6

6 years ago
Landed patch 3:
http://hg.mozilla.org/mozilla-central/rev/86248f7209b7
Attachment #527731 - Flags: review?(peterv) → review+
(Assignee)

Comment 7

6 years ago
Landed patch 2:
https://hg.mozilla.org/mozilla-central/rev/e2d2de2d2894
Attachment #527731 - Flags: checkin+
Attachment #527732 - Flags: checkin+
Attachment #527839 - Attachment is obsolete: true
dbaron, you could probably close this.  2 of 3 patches landed, and the JSTracer stuff in part 1 is going to require additional futzing with the JS engine, so I'll deal with that in its own bug, bug 701415.
(Assignee)

Comment 9

5 years ago
Sounds good.  (And yes, I didn't land patch 1 because it didn't actually do anything useful.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.