The default bug view has changed. See this FAQ.

SetProcessDPIAware is called regardless if the process is really DPI aware

RESOLVED FIXED in mozilla7

Status

()

Core
Widget: Win32
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla7
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 527759 [details] [diff] [review]
fix v1.0

Although it may be fine for all Mozilla products to call SetProcessDPIAware on xul.dll load, in embedding situation it may not be good as the rest of the process may be not DPI aware. The fix is as simple as moving the call to XRE_main, where other similar settings are done.
Attachment #527759 - Flags: review?(roc)
Attachment #527759 - Flags: review?(roc) → review+

Updated

6 years ago
Keywords: checkin-needed
patching file toolkit/xre/nsAppRunner.cpp
Hunk #1 FAILED at 2775
1 out of 1 hunks FAILED -- saving rejects to file toolkit/xre/nsAppRunner.cpp.rej
patching file widget/src/windows/nsToolkit.cpp
Hunk #1 FAILED at 217
1 out of 1 hunks FAILED -- saving rejects to file widget/src/windows/nsToolkit.cpp.rej
Keywords: checkin-needed
(Assignee)

Comment 2

6 years ago
Thanks for an attempt to commit it. I was planning to commit it myself, but my build environment is temporary broken. I will rebase and push once I will fix it.
(Assignee)

Comment 3

6 years ago
Pushed to cedar:
http://hg.mozilla.org/projects/cedar/rev/25e9a51b01be
Whiteboard: fixed-in-cedar
Pushed:
http://hg.mozilla.org/mozilla-central/rev/25e9a51b01be
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.