652120 - Grippy missing from Classic theme menubar on GTK2

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Ian Neal]

Attachment: Override binding and port toolbar.xml changes patch v1.0

The grippy for the menubar in classic theme on linux is no longer present, shows okay under modern and on other platforms.
Easy to fix with a new binding in our classic toolbar.css but whilst here might as well port changes to our toolbar.xml from the following bugs:
Bug 574702 - avoid initializing WindowDraggingUtils multiple times due to binding re-attachment (causes dragging jumpiness issues)
Bug 574861 - Windows should never be movable in fullscreen mode
Bug 555081 - Add support for titlebar mouse interaction and address missing aero features
Bug 575536 - Don't leak WindowDraggingElement into the global scope
Bug 624157 - When maximising window, scroll buttons remain in tab bar

Comment 1

[[e-mail]]

Comment on attachment 527769 [details] [diff] [review]
Override binding and port toolbar.xml changes patch v1.0

>+toolbar[type="menubar"]:not([autohide="true"]):not(:-moz-lwtheme):-moz-system-metric(menubar-drag) {
>+  -moz-binding: url("chrome://communicator/content/bindings/toolbar.xml#grippytoolbar-drag");
[Do we need to care about xpfe="false"? See communicator.css]

Comment 2

[Ian Neal]

Attachment: Override binding and port toolbar.xml changes patch v1.0a [Checked in: Comment 3]

Changes since v1.0:
* Take account of [xpfe="false"]

Carrying forward r=

Comment 3

[Ian Neal]

Comment on attachment 527877 [details] [diff] [review]
Override binding and port toolbar.xml changes patch v1.0a [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/b066f8c46d19
http://hg.mozilla.org/releases/comm-2.0/rev/39cf04be2e0a