65213 - Link Colors" should be "Colors & Effects

Status: RESOLVED INVALID

(SeaMonkey :: Preferences, defect, P4)

Description

[Håkan Waara]

Steps to reproduce:

1. Edit > "Preferences..."
2. Click on "Colors" row under "Appearance".

The groupbox, which title is "Link Colors" should be only "Links". This is
because there's a checkbox, "Underline links" which has nothing to do with "Link
Colors".

I suggest we just change the groupbox's title to "Links".

Comment 1

[Mark Anderson]

I disagree.  The "Underline links" item is the oddball.  It should not be in a 
Colors item under Appearance at all.  It's counter-intuitive to have 
link-modifying information in a place that would be identified with color 
changing.

Comment 2

[Håkan Waara]

Hmm... Perhaps we should rename the whole preferences tab to "Links and Colors"
and rename the groupbox to "Links"?

Mpt: What do you think?

Comment 3

[sairuh (rarely reading bugmail)]

i'd keep the panel title as Colors. renaming the section from Link Colors to
simply Links would be fine with me.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Or, link properties?

Comment 5

[Håkan Waara]

The fact that the panel title "Colors" doesn't have anything to do with the
"Underline links" option annoys me.

My suggestion is that we either move the "Underline links" checkbox to the
"Appearance" panel, or change the panel's title to something more appropriate.

Comment 6

[sairuh (rarely reading bugmail)]

ah, good point, hakan. :) while moving the underline links checkbox to
Appearance sounds logical, unfortunately i think many 4.x might get confused
since that feature has traditionally been in the Colors panel. Colors and Links
[long as it is, though not as long as Mail and Newsgroups --then again, it's a
subpanel] might be okay...? *shrug*

Comment 7

[Håkan Waara]

I think so, "Links and Colors" sounds good to me.

Comment 8

[Håkan Waara]

Attachment: [Patch] Link Colors -> Link Properties. Colors -> Links and Colors.

Comment 9

[Håkan Waara]

Attachment: [Patch] Link Colors -> Link Properties. Colors -> Colors and Links

Comment 10

[Håkan Waara]

Forget about the first patch, I slipped with the mouse: sorry for the spam.

Comment 11

[Matthew T (active 1999-2002)]

> Mpt: What do you think?

| Category:             Colors & Effects ::::::::::::::::::::::::::: |
| +-------------------+                                              |
| |=General===========| [::] _Backgrounds    [@@] _Links             |
| |=Display===========| [##] _Text           [OO] _Recent links      |
| |  Languages        | [@@] _Headings       [**] _Highlighted links |
| |  Fonts            | [OO] _Quoted text                            |
| |::Colors:&:Effects:|      St_yle for quoted text: [Italic    :^]  |
| |  Styles           |                                              |
| |  Multimedia       | [/] Allow documents to use _other colors     |
| |  Filters          | [/] _Underline links                         |
| |  Scripts          |                                              |
| |  Privacy/Security | V Source code colors ----------------------- |
| |                   | [%%] Tag_s           [**] _Errors            |
| |                   |                                              |
| +-------------------+ :::::::::::::::::::::::::::::::::::::::::::: |

Comment 12

[Håkan Waara]

Do we have all that stuff mpt wants us to move to Colors & Effects?

I think it seems rather complex. How about we add my patch temporary, and then
fix the other stuff?

Comment 13

[eddyk]

Instead of "Link Colors", how about "Link Appearance"?  While underlining
doesn't have anything to do with colors, IMHO it makes sense to group it with
the other link properties.

Comment 14

[Håkan Waara]

Sounds like a reasonable idea to me.

Comment 15

[Håkan Waara]

I don't have enough time to promise I'll fix this, thus I'm reassigning to the
default owner of this component. Who knows, maybe I'll get around and fix it
after all - but I can't promise it. Sorry :(

Comment 16

[Hixie (not reading bugmail)]

So what's the bug here? Is it to change the "Link Colors" panel to "Colors & 
Effects" or is it to change the "Link Colors" panel to be all that mpt 
describes it as? (i.e., is it the short term fix or the long term fix?)

Comment 17

[Matthew T (active 1999-2002)]

Adding GUI for those other colors is not required to fix this bug. :-) (Would 
be nice, though ...)

Comment 18

[Håkan Waara]

Eddyk: wanna fix this?

Comment 19

[eddyk]

Sure, I'll take it with the understanding that I'll be changing the wording.  
I'm not ready to change the layout of the panel as proposed by mpt.

Comment 20

[Peter Trudelle]

->hwaara or eddyk?

Comment 21

[eddyk]

Ok, Taking it

Comment 22

[eddyk]

Attachment: updated patch

Comment 23

[Srilatha Moturi]

Comment on attachment 55167 [details] [diff] [review]
updated patch

r=srilatha

Comment 24

[Asa Dotzler [:asa]]

<[e-mail]> email is bouncing. Is this person still involved with
Mozilla? Do these bugs need to be reassigned? 

Comment 25

[timeless]

i think '&' won out over 'and'. hwaara do you want to finish this off?

Comment 26

[Samir Gehani]

Scheduling for 0.9.8 but if someone else wants this they are welcome to take it.

Comment 27

[Samir Gehani]

Prefs traige team: textual changes from one release to the next will throw users
off and potentially cause them to be confused (not to mention the need for
updating docs).  Need a strong reason to change text.

Comment 28

[bugs]

Please consider adding "Active link" (:active) color selection in the
Appearance->Colors dialog, along with some syncing between the
Appearance->Colors and Composer->New page settings dialogs. Their major task is
the same, but the design is completely different (and thus distracting).


ps. File a new bug if it doesn't belong here, but it seems like you are doing
some dialog reconstruction anyway...

Comment 29

[Tim Meader]

Please close... to far out of date to be relavent.

Comment 30

[Håkan Waara]

3 years out of date (at least!)