652139 - C++0x narrowing conversion inside {} compilation error in nsDocumentViewer.cpp

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Patch

This is similar to bug 502301.

The failure looks like the following:
../../../layout/base/nsDocumentViewer.cpp: In member function 'virtual nsresult DocumentViewerImpl::SetMinFontSize(PRInt32)':
../../../layout/base/nsDocumentViewer.cpp:2870:45: error: narrowing conversion of 'aMinFontSize' from 'PRInt32' to 'float' inside { }

See https://bugzilla.mozilla.org/show_bug.cgi?id=502301#c4 as to why this is invalid C++0x.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 527783 [details] [diff] [review]
Patch

Oops, this shouldn't be using ZoomInfo at all.  Instead it should have its own struct that has a PRInt32 member.

Comment 2

[Mike Hommey [:glandium]]

Note this also affects aurora.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Patch

This should work, and is how e.g. SetChildHintCharacterSetSource does it.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 527804 [details] [diff] [review]
Patch

Use NS_INT32_TO_PTR() at the incoming end instead of just a void* cast, and r=dbaron.

Comment 5

[Mike Hommey [:glandium]]

Two questions:
- do you want other similar void* casts changed at the same time? (there's SetChildHintCharacterSetSource and SetChildBidiOptions)
- do you want this fix on aurora ?

Comment 6

[Mike Hommey [:glandium]]

Arg, I missed the mDocument->EnumerateExternalResources(SetExtResourceMinFontSize, &ZoomInfo); a few lines later.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Patch v3

Changing other similar void* casts, and fixing EnumerateExternalResources call.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 527810 [details] [diff] [review]
Patch v3

r=dbaron

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Do you have a good reason this ought to be fixed on Aurora?)

Comment 10

[Mike Hommey [:glandium]]

(In reply to comment #9)
> (Do you have a good reason this ought to be fixed on Aurora?)

None particularly, I can apply the patch locally. I merely asked if you had a wish to fix this on aurora.

Comment 11

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/503696b78379