The default bug view has changed. See this FAQ.

On SM builds on windows, |make check-jstests| fails with a MemoryError

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Paul Biggar, Assigned: evilpie)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-tracemonkey])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
This is probably an error in the test harness.

Log: http://tinderbox.mozilla.org/showlog.cgi?tree=TraceMonkey&errorparser=unittest&logfile=1303482839.1303485372.32239.gz&buildtime=1303482839&buildname=tracemonkey_win32-debug_spidermonkey-nomethodjit&fulltext=1#err0

RC=0; \
	for f in `echo ",m,j,mj,mjp,am,amj,amjp,amd" | tr ',' '\n'`; \
		do \
			 d:/mozilla-build/python25/python2.5.exe -u ../../src/js/src/tests/jstests.py \
				--tinderbox --no-progress \
				--no-extensions \
				--timeout 300 \
				--args="`echo $f | sed 's/\(.\)/ -\1/g'`" \
				/e/builds/moz2_slave/tm-w32-dbg-spidermonkey-nomethodjit/objdir/dist/bin/js.exe; \
			RC=$(( $RC || $?)); \
		done; \
	exit $RC
Traceback (most recent call last):
  File "../../src/js/src/tests/jstests.py", line 301, in <module>
    xul_info = manifest.XULInfo.create(JS)
  File "e:\builds\moz2_slave\tm-w32-dbg-spidermonkey-nomethodjit\src\js\src\tests\manifest.py", line 42, in create
    dirs = split_path_into_dirs(os.getcwd()) + split_path_into_dirs(jsdir)
  File "e:\builds\moz2_slave\tm-w32-dbg-spidermonkey-nomethodjit\src\js\src\tests\manifest.py", line 15, in split_path_into_dirs
    dirs.append(path)
MemoryError
You need to do something to turn these not-orange again.  It's not cool leaving builds permanently orange like this.  Please fix this on Windows, temporarily disable whatever bit of functionality is going wrong on Windows until you can fix it, or back out the original change.
(Reporter)

Comment 2

6 years ago
This has been disabled.


(In reply to comment #1)
> It's not cool leaving
> builds permanently orange like this.

Sorry, I didn't intend to leave the builds orange. In my defense, the windows builds didn't turn orange for 500 minutes, which was 4am Saturday my time (partly due to being asked to delay pushing the fix until bug 652127 was fixed).
(Reporter)

Updated

6 years ago
Blocks: 652408
(Reporter)

Updated

6 years ago
No longer blocks: 647482
(Assignee)

Updated

6 years ago
Assignee: general → evilpies
(Assignee)

Comment 3

6 years ago
Created attachment 529991 [details] [diff] [review]
More sane path reversal
Attachment #529991 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #529991 - Flags: review? → review?(pbiggar)
(Reporter)

Comment 4

6 years ago
Comment on attachment 529991 [details] [diff] [review]
More sane path reversal

Review of attachment 529991 [details] [diff] [review]:

Nice fix, thanks.
Attachment #529991 - Flags: review?(pbiggar) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/tracemonkey/rev/f9e703262482
(Assignee)

Updated

6 years ago
Whiteboard: [fixed-in-tracemonkey]
(Assignee)

Comment 6

6 years ago
Forgot to add a reportCompare to the end of the test, somehow didn't catch this locally. 
https://hg.mozilla.org/tracemonkey/rev/ec82b6f20c8f
(Reporter)

Comment 7

6 years ago
(In reply to comment #6)
> Forgot to add a reportCompare to the end of the test, somehow didn't catch
> this locally. 
> https://hg.mozilla.org/tracemonkey/rev/ec82b6f20c8f

Think you got the wrong bug here.
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/f9e703262482
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.