Closed Bug 652162 Opened 11 years ago Closed 11 years ago

Firefox 3.6.16 not getting advertised updates on Beta channel for 3.6.17 build 2

Categories

(Release Engineering :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: abillings, Unassigned)

Details

We released a 3.6.17 build 2 beta on Monday, 4/18. We've noticed a lack of users in beta channel for 3.6.17 since. 

I fired up a Win7 Pro VM, installed 3.6.16, changed the channel pref to "beta" and changed these values in about:config:

app.update.idletime = 1
app.update.interval = 60
app.update.timer = 60000

I left it idle for five minutes and did not get any prompt for the beta. There is a problem somewhere, possibly in the update settings server side.
Were you able to get a manual update?
Yes, manual updates work fine.
The values look right
interval is 60 seconds
timer fires every 60 seconds

Just checked with a nightly namoroka and it performed a background check and downloaded the update. This could happen if the last update check was in the recent past it won't perform the check as well. It just came to mind that you could instead of changing the app.update.interval preference value (which has caused several invalid bug reports) you could change or add the following integer pref

app.update.lastUpdateTime.background-update-timer

and make the value 1000000000

I'll check if the beta channel works for me.
Just tried build 2 from
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/3.6.17-candidates/build2/win32/en-US/
using
app.update.idletime = 1
app.update.interval = default value
app.update.timer = 60000
app.update.lastUpdateTime.background-update-timer = 100000

on the beta channel and it downloaded the update fine. I also applied the update.

Just tried it with 3.6.16 and it appears that the update xml returned by AUS is empty.

Here is the url
https://aus2.mozilla.org/update/3/Firefox/3.6.16/20110319135224/WINNT_x86-msvc/en-US/beta/Windows_NT%206.1/default/default/update.xml

Moving over to AUS since the client appears to be working correctly.

Al, could you update your docs to only change the following prefs to the following values for 3.6.x?
app.update.idletime = 1
app.update.timer = 60000
app.update.lastUpdateTime.background-update-timer = 100000

For 4.0 we got rid of the app.update.timer pref and it now schedules firing the timer as needed with the first firing happening after 2 minutes for the first timer that needs to fire and in another 2 minutes.
Assignee: nobody → morgamic
Component: Application Update → General
Product: Toolkit → AUS
QA Contact: application.update → general
Version: unspecified → 2.0
Also verified that I am prompted to download the update when set to prompt vs. download in the background using build 2 from
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/3.6.17-candidates/build2/win32/en-US/
(In reply to comment #4)
> Just tried build 2 from
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/3.6.17-candidates/build2/win32/en-US/
> using
> app.update.idletime = 1
> app.update.interval = default value
> app.update.timer = 60000
> app.update.lastUpdateTime.background-update-timer = 100000
> 
> on the beta channel and it downloaded the update fine. I also applied the
> update.

 So that worked...
 
> Just tried it with 3.6.16 and it appears that the update xml returned by AUS is
> empty.

But this implies it doesn't work?

What is the difference in behavior?
I used Firefox 3.6.16 release on Windows, changed the channel to beta, and tried to update. That resulted in the following url
https://aus2.mozilla.org/update/3/Firefox/3.6.16/20110319135224/WINNT_x86-msvc/en-US/beta/Windows_NT%206.1/default/default/update.xml

I just now opened the url again and there were no updates available as shown by the contents being:
<?xml version="1.0"?>
<updates>
</updates>
For clarity, that means the AUS server is not advertising the update to 3.6.16 when it is changed to the beta channel.
Severity: normal → blocker
btw: In the past when this has happened I've asked QA to turn on app update logging by setting or adding the boolean pref app.update.log to true, checking for updates, then checking the error console for the update url. You can then copy the url and paste it in a tab to see if AUS is advertising the update and either talking with releng on irc should provide info as to what's going on or file an AUS bug.
Assignee: morgamic → nobody
Component: General → Release Engineering
Product: AUS → mozilla.org
QA Contact: general → release
Version: 2.0 → other
Priority: -- → P1
I'm going to try pushing the build2 beta snippets again. There's no real indication in the build notes whether that was actually ever done or not.
(In reply to comment #10)
> I'm going to try pushing the build2 beta snippets again. There's no real
> indication in the build notes whether that was actually ever done or not.

This is done. Should we retest anything at this point?
coop, the update url in comment #7 is generated from a Firefox 3.6.16 build. It still returns an empty update. I also verified it isn't cached on my client. Perhaps it is cached on the server side?
https://aus2.mozilla.org/update/3/Firefox/3.6.16/20110319135224/WINNT_x86-msvc/en-US/beta/Windows_NT%206.1/default/default/update.xml
Interesting, the update is only offered with the force=1 param and Al is trying to test a background check which won't have the force=1 param... so, it is now available for manual checks whereas it wasn't before.

So, the following url doesn't return an update
https://aus2.mozilla.org/update/3/Firefox/3.6.16/20110319135224/WINNT_x86-msvc/en-US/beta/Windows_NT%206.1/default/default/update.xml

and this will
https://aus2.mozilla.org/update/3/Firefox/3.6.16/20110319135224/WINNT_x86-msvc/en-US/beta/Windows_NT%206.1/default/default/update.xml?force=1
I'm trying to touch all of the beta snippets to get them re-synced, but if forcing is actually working, I'm out of my depth.

Have there been any server-side changes in the past week?
I know the force parameter was configured to allow 3.6.15 and then 3.6.16 users to update to 4.0 at some point. I don't know the inner mechanics of AUS so can't help beyond that info at this time.
OS: Mac OS X → All
Hardware: x86 → All
(In reply to comment #15)
> I know the force parameter was configured to allow 3.6.15 and then 3.6.16 users
> to update to 4.0 at some point. I don't know the inner mechanics of AUS so
> can't help beyond that info at this time.

Do you remember who did that work?
No... I wasn't involved in it. LegNeato might know and I suspect it was nthomas who is out.
If I'm reading your AUS configs right, then both 3.5.18 and 3.6.16 are completely throttled on anything that isn't betatest or releasetest:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/webtools/aus/xml/inc/config-dist.php&rev=1.131&mark=88-93,108-115#88

Hence AUS is doing as it has previously been told...
That looks right to me as well though I haven't looked at the config format all that often.

So, adding 'beta' to the 3.6.16 throttleExceptions array should fix this.
This is a standard set of AUS patches we apply for every release that got missed this time for both 3.6.17 and 3.5.19.

Once the AUS server is updated (bug 652218), this should right itself.
(In reply to comment #20)
> This is a standard set of AUS patches we apply for every release that got
> missed this time for both 3.6.17 and 3.5.19.
iirc we normally update the AUS server with these unthrottle patches after we go to beta. We should have done this at 10.40 this morning, but dropped the ball, with so many people out today. Sorry.

> Once the AUS server is updated (bug 652218), this should right itself.
Correct.
(In reply to comment #20)
> Once the AUS server is updated (bug 652218), this should right itself.

The aforementioned snippet isn't empty any more (when force is not specified):

https://aus2.mozilla.org/update/3/Firefox/3.6.16/20110319135224/WINNT_x86-msvc/en-US/beta/Windows_NT%206.1/default/default/update.xml
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Just double checking here but when I use the settings in comment 4, I don't see the notification.  If I check the Help menu after a while I see a "Download Firefox 3.6.17" entry, but no notification.

This is for Firefox 3.6.16 on beta channel.
It appears the app.update.lastUpdateTime.background-update-timer needs to be larger... I typically just modify the existing value as follows:
1303518430
1203518430

or you can just use 1000000000

app.update.idletime = 1
app.update.interval = default value
app.update.timer = 60000
app.update.lastUpdateTime.background-update-timer = 1000000000
Still no notification -- only see the "Download..." entry in the Help menu.
Anthony, let's take this to in person or email so the people cc'd to the bug aren't spammed.
Al, you should also be able to get Al to help you out since per comment #6 it worked for him.
(In reply to comment #28)
> Al, you should also be able to get Al to help you out since per comment #6 it
> worked for him.
Meant for Anthony not Al and now I'm spamming the bug
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.