Closed Bug 652179 Opened 13 years ago Closed 12 years ago

MIPS: Select endian/float tests on target

Categories

(Core Graveyard :: Nanojit, defect)

Product:
Core Graveyard
Component:
Nanojit
Platform:
Other
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: chris, Assigned: rreitmai)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin)

Attachments

(1 file, 1 obsolete file)

Select endianess/float support on target
2.06 KB, patch
n.nethercote
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.16) Gecko/20110323 Ubuntu/10.10 (maverick) Firefox/3.6.16
Build Identifier: 

Update the test script for MIPS to select endian and float tests based on target

Reproducible: Always

Steps to Reproduce:
Run make check on a little endian target

Actual Results:  
TEST-UNEXPECTED-FAIL | lirasm | lirasm  --execute ../../lirasm/tests/bigendian/lduc2ui.in
expected output
Output is: 0
actual output
Output is: 53


Expected Results:  
TEST-PASS | lirasm | lirasm  --execute ../../lirasm/tests/littleendian/lduc2ui.in


There are other problems in the testsuite to do with unimplemented opcodes but the first part is to make sure the correct tests are run

        Attachment #527824 -
        Flags: review?(nnethercote)

    
    

    
  


  
This is the corrected version of the patch that uses NJ_SOFTFLOAT_SUPPORTED instead of NJ_SOFTFLOAT

        Attachment #527824 -
        Attachment is obsolete: true

        Attachment #527824 -
        Flags: review?(nnethercote)

    
    

    
  
Comment on attachment 527825 [details] [diff] [review]
Select endianess/float support on target

Review of attachment 527825 [details] [diff] [review]:

r=me

        Attachment #527825 -
        Flags: review+

    
  
Whiteboard: checkin-needed

    
    

    
  
Can this be checked? I do not have commit access

    
    

    
  
Take for landing.
Assignee: nobody → rreitmai
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  
chris http://hg.mozilla.org/projects/nanojit-central/rev/fb43ee866e23
Whiteboard: checkin-needed → checkin-needed,fixed-in-nanojit
Whiteboard: checkin-needed,fixed-in-nanojit → fixed-in-nanojit

    
  
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin

    
  
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: