MIPS: Select endian/float tests on target

RESOLVED FIXED

Status

Core Graveyard
Nanojit
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: Chris Dearman, Assigned: Rick Reitmaier)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.16) Gecko/20110323 Ubuntu/10.10 (maverick) Firefox/3.6.16
Build Identifier: 

Update the test script for MIPS to select endian and float tests based on target

Reproducible: Always

Steps to Reproduce:
Run make check on a little endian target

Actual Results:  
TEST-UNEXPECTED-FAIL | lirasm | lirasm  --execute ../../lirasm/tests/bigendian/lduc2ui.in
expected output
Output is: 0
actual output
Output is: 53


Expected Results:  
TEST-PASS | lirasm | lirasm  --execute ../../lirasm/tests/littleendian/lduc2ui.in


There are other problems in the testsuite to do with unimplemented opcodes but the first part is to make sure the correct tests are run
(Reporter)

Comment 1

6 years ago
Created attachment 527824 [details] [diff] [review]
Select endianess/float support on target
Attachment #527824 - Flags: review?(nnethercote)
(Reporter)

Comment 2

6 years ago
Created attachment 527825 [details] [diff] [review]
Select endianess/float support on target

This is the corrected version of the patch that uses NJ_SOFTFLOAT_SUPPORTED instead of NJ_SOFTFLOAT
Attachment #527824 - Attachment is obsolete: true
Attachment #527824 - Flags: review?(nnethercote)
Comment on attachment 527825 [details] [diff] [review]
Select endianess/float support on target

Review of attachment 527825 [details] [diff] [review]:

r=me
Attachment #527825 - Flags: review+
(Reporter)

Updated

6 years ago
Whiteboard: checkin-needed
(Reporter)

Comment 4

6 years ago
Can this be checked? I do not have commit access
(Assignee)

Comment 5

6 years ago
Take for landing.
Assignee: nobody → rreitmai
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 6

6 years ago
chris http://hg.mozilla.org/projects/nanojit-central/rev/fb43ee866e23
Whiteboard: checkin-needed → checkin-needed,fixed-in-nanojit
Whiteboard: checkin-needed,fixed-in-nanojit → fixed-in-nanojit

Updated

6 years ago
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.